[
https://issues.apache.org/jira/browse/TWILL-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115190#comment-16115190
]
ASF GitHub Bot commented on TWILL-241:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/59#discussion_r131511349
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillRuntimeSpecification.java
---
@@ -87,19 +86,46 @@ public String getTwillAppName() {
return twillAppName;
}
- public int getReservedMemory() {
- return reservedMemory;
+ /**
+ * Returns the minimum heap ratio for the application master.
+ */
+ public double getAMMinHeapRatio() {
+ return getMinHeapRatio(config);
+ }
+
+ /**
+ * Returns the minimum heap ratio for the given runnable.
+ */
+ public double getMinHeapRatio(String runnableName) {
+ return getMinHeapRatio(runnableConfigs.containsKey(runnableName) ?
runnableConfigs.get(runnableName) : config);
--- End diff --
Agree. Get it wrong after some refactoring
> Allow specifying reserved off-heap memory and extra JVM options per runnable
> ----------------------------------------------------------------------------
>
> Key: TWILL-241
> URL: https://issues.apache.org/jira/browse/TWILL-241
> Project: Apache Twill
> Issue Type: Improvement
> Components: api, yarn
> Affects Versions: 0.11.0
> Reporter: Andreas Neumann
> Assignee: Terence Yim
> Fix For: 0.12.0
>
>
> Sometimes, a particular runnable needs a lot more off-heap memory than
> others. It would therefore be useful to specify the amount of reserved
> non-heap memory per runnable.
> Similarly, for example, for debugging purposes, it may be necessary to add a
> JVM option for one of the runnables without affecting the other runnables of
> the same application.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
