Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/58#discussion_r131762593
  
    --- Diff: 
twill-yarn/src/test/java/org/apache/twill/yarn/ProvisionTimeoutTestRun.java ---
    @@ -85,13 +105,29 @@ public TimeoutAction 
launchTimeout(Iterable<TimeoutEvent> timeoutEvents) {
             return TimeoutAction.recheck(10, TimeUnit.SECONDS);
           }
         }
    +
    +    @Override
    +    public void aborted() {
    +      try {
    +        new 
File(context.getSpecification().getConfigs().get("parentFolderPath") + 
File.separator
    --- End diff --
    
    When constructing file, usually not to use `File.separator`, but instead 
use the constructor `File(File parent, String path)`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to