Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/incubator-twill/pull/49#discussion_r33199937
  
    --- Diff: 
twill-core/src/main/java/org/apache/twill/launcher/TwillLauncher.java ---
    @@ -171,7 +172,7 @@ private static URLClassLoader createClassLoader(File 
dir, boolean useClassPath)
               }
             }
           }
    -
    +      urls.addAll(getClassPaths("$" + EnvKeys.YARN_CLASSPATH));
    --- End diff --
    
    Feel like we better provide an option in the `TwillPreparer` to say whether 
want to include yarn application classpath or not.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to