Github user chtyim commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/49#discussion_r33200392
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java ---
@@ -351,7 +352,8 @@ private Credentials createCredentials() {
}
private ApplicationBundler createBundler() {
- return new ApplicationBundler(ImmutableList.<String>of());
+ // exclude hadoop packages as they are included by expanding
"$YARN_CLASSPATH" while Constructing the classLoader
+ return new
ApplicationBundler(ImmutableList.<String>of("org.apache.hadoop"));
--- End diff --
We actually need better than just an exclude list. Excluding
"org.apache.hadoop" will exclude HBase classes as well, which some application
may depends on. Probably better to make ApplicationBundler takes a Predicate
and have a Predicate instance being set to the TwillPreparer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
