Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/incubator-twill/pull/49#discussion_r33216780
  
    --- Diff: twill-core/src/main/java/org/apache/twill/internal/EnvKeys.java 
---
    @@ -44,6 +44,9 @@
     
       public static final String TWILL_LOG_KAFKA_ZK = "TWILL_LOG_KAFKA_ZK";
     
    +  public static final String YARN_APPLICATION_CLASSPATH = 
"YARN_APPLICATION_CLASSPATH";
    +  public static final String INCLUDE_YARN_APPLICATION_CLASSPATH = 
"INCLUDE_YARN_APPLICATION_CLASSPATH";
    --- End diff --
    
    I don't think we need two env variables. You can just not setting 
`YARN_APPLICATION_CLASSPATH` if user decided not to use it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to