Github user tnine commented on a diff in the pull request:
https://github.com/apache/incubator-usergrid/pull/250#discussion_r30518223
--- Diff:
stack/services/src/main/java/org/apache/usergrid/services/assets/data/S3BinaryStore.java
---
@@ -149,38 +150,52 @@ public void write( final UUID appId, final Entity
entity, InputStream inputStrea
IOUtils.closeQuietly( os );
}
- BlobBuilder.PayloadBlobBuilder bb =
- blobStore.blobBuilder( uploadFileName ).payload(
tempFile ).calculateMD5().contentType( mimeType );
-
fileMetadata.put( AssetUtils.CONTENT_LENGTH, written );
- if ( fileMetadata.get( AssetUtils.CONTENT_DISPOSITION ) !=
null ) {
- bb.contentDisposition( fileMetadata.get(
AssetUtils.CONTENT_DISPOSITION ).toString() );
- }
- final Blob blob = bb.build();
- final File finalTempFile = tempFile;
- final ListenableFuture<String> future =
- blobStore.putBlob( bucketName, blob,
PutOptions.Builder.multipart() );
+ // JClouds no longer supports async blob store, so we have to
do this fun stuff
- Runnable listener = new Runnable() {
+ LOG.debug( "Starting upload thread" );
+
+ Thread uploadThread = new Thread( new Runnable() {
@Override
public void run() {
try {
- String eTag = future.get();
+ LOG.debug( "S3 upload thread started" );
--- End diff --
Can we use an executor pool with a queue and a callable? This way we wont'
create a lot of threads that may use our file handles during uploads.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
