Github user snoopdave commented on a diff in the pull request:

    https://github.com/apache/incubator-usergrid/pull/250#discussion_r30548737
  
    --- Diff: 
stack/services/src/main/java/org/apache/usergrid/services/assets/data/S3BinaryStore.java
 ---
    @@ -134,10 +134,11 @@ public void write( final UUID appId, final Entity 
entity, InputStream inputStrea
             }
             else { // bigger than 5mb... dump 5 mb tmp files and upload from 
them
     
    -            // todo: yes, AsyncBlobStore is deprecated, but there appears 
to be no replacement yet
    -            final AsyncBlobStore blobStore = 
getContext().getAsyncBlobStore();
    +            // create temp file and copy entire file to that temp file
     
    -            File tempFile = File.createTempFile( 
entity.getUuid().toString(), "tmp" );
    +            LOG.debug( "Writing temp file for S3 upload" );
    --- End diff --
    
    Todd, it appears that we (unintentionally?) limit file size to 10 mb, 
because we read 5pm and then on this line we only only read up to 5 pm more: 
https://goo.gl/sf0Tof


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to