Github user rgex commented on a diff in the pull request:
https://github.com/apache/incubator-usergrid/pull/250#discussion_r30582032
--- Diff:
stack/services/src/main/java/org/apache/usergrid/services/assets/data/S3BinaryStore.java
---
@@ -134,10 +134,11 @@ public void write( final UUID appId, final Entity
entity, InputStream inputStrea
}
else { // bigger than 5mb... dump 5 mb tmp files and upload from
them
- // todo: yes, AsyncBlobStore is deprecated, but there appears
to be no replacement yet
- final AsyncBlobStore blobStore =
getContext().getAsyncBlobStore();
+ // create temp file and copy entire file to that temp file
- File tempFile = File.createTempFile(
entity.getUuid().toString(), "tmp" );
+ LOG.debug( "Writing temp file for S3 upload" );
--- End diff --
I agree with tnine that we should add a max file size parameter that is
configurable in the config file.
If configuring a max file size using tomcat we wont get a nice JSON error
message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
