[ https://issues.apache.org/jira/browse/VELOCITY-681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergiu Dumitriu updated VELOCITY-681: ------------------------------------- Description: The fix for VELOCITY-615 was too radical, since it completely disables #setting new values to the formal arguments. A minimalistic example that used to work up to 1.6 (but not with 1.6.1) is: {noformat} #macro(myMacro $result) #set($result = 'some value') #end #myMacro($x) $x {/noformat} which prints $x (as an undefined variable). was: The fix for VELOCITY-615 was too radical, since it completely disables #setting new values to the formal arguments. A minimalistic example that used to work up until 1.6 is: {noformat} #macro(myMacro $result) #set($result = 'some value') #end #myMacro($x) $x {/noformat} which prints $x (as an undefined variable). > [regression] Changes on the macro parameters are not persisted outside the > macro call > ------------------------------------------------------------------------------------- > > Key: VELOCITY-681 > URL: https://issues.apache.org/jira/browse/VELOCITY-681 > Project: Velocity > Issue Type: Bug > Components: Engine > Affects Versions: 1.6.1 > Reporter: Sergiu Dumitriu > Priority: Critical > Fix For: 1.6.2, 1.7 > > Attachments: VELOCITY-681-1.6.patch, VELOCITY-681-trunk.patch > > > The fix for VELOCITY-615 was too radical, since it completely disables > #setting new values to the formal arguments. A minimalistic example that used > to work up to 1.6 (but not with 1.6.1) is: > {noformat} > #macro(myMacro $result) > #set($result = 'some value') > #end > #myMacro($x) > $x > {/noformat} > which prints $x (as an undefined variable). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org