[
https://issues.apache.org/jira/browse/VELOCITY-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667828#action_12667828
]
Nathan Bubna commented on VELOCITY-681:
---------------------------------------
If Jarkko (who knows the .literal stuff best) gives this patch an "all clear"
soon, then i'd say we should get it in before releasing 1.6.2. If, however,
the 72 hours is up and Claude has the votes to do the release and we still have
heard an "all clear" on this, then i think we should just let the release
proceed and "take our lumps" for the behavior change in a bugfix release.
Sergiu and any other users who depended on the 1.5/1.6 behavior here will have
to adapt eventually for 1.7 anyway and can patch their personal 1.6.2 version
if desparate in the meantime.
So, i think, if the latest release files look good when i check them out, i'll
vote like this:
(jarkko gives all clear on 681 patch) ? -1 : +1
:)
> [regression] Changes on the macro parameters are not persisted outside the
> macro call
> -------------------------------------------------------------------------------------
>
> Key: VELOCITY-681
> URL: https://issues.apache.org/jira/browse/VELOCITY-681
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 1.6.1
> Reporter: Sergiu Dumitriu
> Priority: Critical
> Fix For: 1.6.2, 1.7
>
> Attachments: VELOCITY-681-1.6.patch, VELOCITY-681-trunk.patch
>
>
> The fix for VELOCITY-615 was too radical, since it completely disables
> #setting new values to the formal arguments. A minimalistic example that used
> to work up to 1.6 (but not with 1.6.1) is:
> {noformat}
> #macro(myMacro $result)
> #set($result = 'some value')
> #end
> #myMacro($x)
> $x
> {/noformat}
> which prints $x (as an undefined variable).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
