[
https://issues.apache.org/jira/browse/VELOCITY-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666616#action_12666616
]
Sergiu Dumitriu commented on VELOCITY-681:
------------------------------------------
Agreed, this is not the expected behavior, but still we had some macros that
depended on it. And given that this behavior has just recently been changed
(and in a minor release), it should be changed back.
The .literal.$varName was used so that assigning a value to a read-only proxy
should still work (VELOCITY-615). I don't know exactly what is it supposed to
do, but since it was already used as a local alias, and the kind of change
VELOCITY-615 does is a local change, it seemed to be the right thing to modify.
Creating a local variable meant that the proxy will be completely hidden after
the first change, and changing the proxy is not possible at all.
> [regression] Changes on the macro parameters are not persisted outside the
> macro call
> -------------------------------------------------------------------------------------
>
> Key: VELOCITY-681
> URL: https://issues.apache.org/jira/browse/VELOCITY-681
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 1.6.1
> Reporter: Sergiu Dumitriu
> Priority: Critical
> Fix For: 1.6.2, 1.7
>
> Attachments: VELOCITY-681-1.6.patch, VELOCITY-681-trunk.patch
>
>
> The fix for VELOCITY-615 was too radical, since it completely disables
> #setting new values to the formal arguments. A minimalistic example that used
> to work up to 1.6 (but not with 1.6.1) is:
> {noformat}
> #macro(myMacro $result)
> #set($result = 'some value')
> #end
> #myMacro($x)
> $x
> {/noformat}
> which prints $x (as an undefined variable).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
