[
https://issues.apache.org/jira/browse/WHIRR-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134821#comment-13134821
]
Andrei Savu commented on WHIRR-49:
----------------------------------
I think we are almost done. Great job!
Some things I've noticed:
* use the same indenting rules in all files - 2 spaces - both for new and old
code (I know this is annoying but consistency improves readability) - I'm
reviewing the patch uploaded 24/Oct/11 19:20 - is this the latest version?
* when creating remote files I think it's better to use
Statements.createOrOverwriteFile or Statements.appendFile as needed
* is it really a good idea to store the cookbooks in /tmp? How about /etc/chef?
Or /opt?
* I think we need a way to specify both the cookbooks repo and the revision
* can we make the exclude cookbooks a config property? does it make sense?
* install_chef_deb() & install_chef_rpm() are only used for installing git - we
should rename them (install_git() in services/common ?)
* there are still some commented test methods in integration tests.
* remember to add whirr-chef to cli/pom.xml
I can help you test on aws-ec2 as soon as we manage to solve WHIRR-410.
It's going to be awesome if we ship 0.7.0 with support for both Puppet and
Chef!
> Allow Whirr to use Chef for configuration management
> ----------------------------------------------------
>
> Key: WHIRR-49
> URL: https://issues.apache.org/jira/browse/WHIRR-49
> Project: Whirr
> Issue Type: New Feature
> Components: core
> Reporter: Jeff Hammerbacher
> Attachments: WHIRR-49-cc.patch, WHIRR-49-pom.patch, WHIRR-49.patch,
> WHIRR-49.patch, WHIRR-49.patch, WHIRR-49.patch, WHIRR-49.patch,
> WHIRR-49.patch, WHIRR-49.patch, WHIRR-49.patch, WHIRR-49.patch,
> WHIRR-49.patch, WHIRR-49.patch, WHIRR-49.patch
>
>
> As discussed in
> https://cwiki.apache.org/confluence/display/WHIRR/WhirrDesign, Whirr should
> be agnostic to the tool used to bring the images up to a state where they're
> ready to run the service.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
