[
https://issues.apache.org/jira/browse/WHIRR-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134911#comment-13134911
]
David Alves commented on WHIRR-49:
----------------------------------
{quote}
1 - use the same indenting rules in all files - 2 spaces - both for new and
old code (I know this is annoying but consistency improves readability) - I'm
reviewing the patch uploaded 24/Oct/11 19:20 - is this the latest version?
2- when creating remote files I think it's better to use
Statements.createOrOverwriteFile or Statements.appendFile as needed
3- is it really a good idea to store the cookbooks in /tmp? How about
/etc/chef? Or /opt?
4- I think we need a way to specify both the cookbooks repo and the revision
5- can we make the exclude cookbooks a config property? does it make sense?
6- install_chef_deb() & install_chef_rpm() are only used for installing git
- we should rename them (install_git() in services/common ?)
7- there are still some commented test methods in integration tests.
8- remember to add whirr-chef to cli/pom.xml
{quote}
1 - wrong patch. done!
2 - Statements.createOrOverwriteFile doesn't exist for me is it in trunk?
3 - the cookbooks are a "temporary download" IMHO, they are not config files
(etc/tmp/) or binaries so I could go either way, maybe they should go wherever
apt stuff goes
4 - right now they are bound to a revision we know works and use the main
opscode repo, maybe that could be an improvement on another jira?
5 - that depends on the revision we are using, see 4
6 - agreed, but again that should probably go in on another jira right? (push
chef whn its ready then use another jira to do that all over)
7 - wrong patch. done1
8 - done!
> Allow Whirr to use Chef for configuration management
> ----------------------------------------------------
>
> Key: WHIRR-49
> URL: https://issues.apache.org/jira/browse/WHIRR-49
> Project: Whirr
> Issue Type: New Feature
> Components: core
> Reporter: Jeff Hammerbacher
> Attachments: WHIRR-49-cc.patch, WHIRR-49-pom.patch, WHIRR-49.patch,
> WHIRR-49.patch, WHIRR-49.patch, WHIRR-49.patch, WHIRR-49.patch,
> WHIRR-49.patch, WHIRR-49.patch, WHIRR-49.patch, WHIRR-49.patch,
> WHIRR-49.patch, WHIRR-49.patch, WHIRR-49.patch, WHIRR-49.patch
>
>
> As discussed in
> https://cwiki.apache.org/confluence/display/WHIRR/WhirrDesign, Whirr should
> be agnostic to the tool used to bring the images up to a state where they're
> ready to run the service.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
