The patch that is attached to this issue fixes the unit test, and doesn't fail the other tests.
Disadvantage: request pages will be detached twice. Not sure if that is a real problem. Martijn On Thu, Feb 26, 2009 at 3:39 PM, Martijn Dashorst (JIRA) <j...@apache.org> wrote: > > [ > https://issues.apache.org/jira/browse/WICKET-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > Martijn Dashorst updated WICKET-2130: > ------------------------------------- > > Attachment: wicket-2130.tgz > > untar in jdk-1.4/wicket > > generates a testcase package in src/test/java/org/apache/wicket/wicket2130 > > Run the tests to see it fail. > > >> Pages stored in Session.touchedPages aren't detached when part of ModalWindow >> ----------------------------------------------------------------------------- >> >> Key: WICKET-2130 >> URL: https://issues.apache.org/jira/browse/WICKET-2130 >> Project: Wicket >> Issue Type: Bug >> Components: wicket >> Affects Versions: 1.3.5, 1.4-RC2 >> Reporter: Martijn Dashorst >> Fix For: 1.3.6, 1.4-RC3 >> >> Attachments: wicket-2130.tgz >> >> >> Creating a ModalWindow with a Page causes the newly constructed page not to >> be detached. >> The page is stored in Session.touchedPages, but that list isn't properly >> processed at the end of the request for detaching. >> I'll try to create a testcase for this. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > -- Become a Wicket expert, learn from the best: http://wicketinaction.com Apache Wicket 1.3.5 is released Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.