there were a lot of good ideas in 2.0 that never made it back. -igor
On Thu, Feb 26, 2009 at 12:17 PM, Martin Benda <[email protected]> wrote: > Exactly what I proposed approx. two years ago :-) There were some > detaching issues with AJAX requests in wicket-2.0 and this approach > (queuing detachables to a request-scoped SET and detaching its contents > at the end of a request) worked very well fo us... > > Regards, > Bendis > > Igor Vaynberg píše v Čt 26. 02. 2009 v 09:50 -0800: >> since there can be more then one request target per request cycle we >> should make the targets queue detachables into a detachable SET and >> detach everything in the set at the end of request. that might work >> elegantly. >> >> -igor >> >> On Thu, Feb 26, 2009 at 9:40 AM, Martijn Dashorst >> <[email protected]> wrote: >> > Then might I suggest that we remove detachment from all *Targets and >> > centralize it in either Session or RequestCycle? >> > >> > I tried using the ATTACHED flag, but that is troublesome when the Page >> > is not attached, but some of its child components are... >> > >> > We could add metadata on the page, and remove it at the end of the >> > request on whether it had been detached or not... >> > >> > Martijn >> > >> > On Thu, Feb 26, 2009 at 6:34 PM, Igor Vaynberg <[email protected]> >> > wrote: >> >> it might be a problem. detaching is expensive as it traverses the >> >> component hierarchy. if there is a way to avoid that we should look >> >> for it. >> >> >> >> -igor >> >> >> >> On Thu, Feb 26, 2009 at 7:01 AM, Martijn Dashorst >> >> <[email protected]> wrote: >> >>> The patch that is attached to this issue fixes the unit test, and >> >>> doesn't fail the other tests. >> >>> >> >>> Disadvantage: request pages will be detached twice. >> >>> >> >>> Not sure if that is a real problem. >> >>> >> >>> Martijn >> >>> >> >>> On Thu, Feb 26, 2009 at 3:39 PM, Martijn Dashorst (JIRA) >> >>> <[email protected]> wrote: >> >>>> >> >>>> [ >> >>>> https://issues.apache.org/jira/browse/WICKET-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel >> >>>> ] >> >>>> >> >>>> Martijn Dashorst updated WICKET-2130: >> >>>> ------------------------------------- >> >>>> >> >>>> Attachment: wicket-2130.tgz >> >>>> >> >>>> untar in jdk-1.4/wicket >> >>>> >> >>>> generates a testcase package in >> >>>> src/test/java/org/apache/wicket/wicket2130 >> >>>> >> >>>> Run the tests to see it fail. >> >>>> >> >>>> >> >>>>> Pages stored in Session.touchedPages aren't detached when part of >> >>>>> ModalWindow >> >>>>> ----------------------------------------------------------------------------- >> >>>>> >> >>>>> Key: WICKET-2130 >> >>>>> URL: https://issues.apache.org/jira/browse/WICKET-2130 >> >>>>> Project: Wicket >> >>>>> Issue Type: Bug >> >>>>> Components: wicket >> >>>>> Affects Versions: 1.3.5, 1.4-RC2 >> >>>>> Reporter: Martijn Dashorst >> >>>>> Fix For: 1.3.6, 1.4-RC3 >> >>>>> >> >>>>> Attachments: wicket-2130.tgz >> >>>>> >> >>>>> >> >>>>> Creating a ModalWindow with a Page causes the newly constructed page >> >>>>> not to be detached. >> >>>>> The page is stored in Session.touchedPages, but that list isn't >> >>>>> properly processed at the end of the request for detaching. >> >>>>> I'll try to create a testcase for this. >> >>>> >> >>>> -- >> >>>> This message is automatically generated by JIRA. >> >>>> - >> >>>> You can reply to this email to add a comment to the issue online. >> >>>> >> >>>> >> >>> >> >>> >> >>> >> >>> -- >> >>> Become a Wicket expert, learn from the best: http://wicketinaction.com >> >>> Apache Wicket 1.3.5 is released >> >>> Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3. >> >>> >> >> >> > >> > >> > >> > -- >> > Become a Wicket expert, learn from the best: http://wicketinaction.com >> > Apache Wicket 1.3.5 is released >> > Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3. >> > > >
