Hi!

Starting this discussion because as it turned out there is a need among the
committers to establish a common code formatting in wicketstuff. [1] So
maybe it is time to have a bit of brainstorming about it. How to do it? What
should it cover? What do you think?

Having a common code formatting would ease the cross work between the
wicketstuff projects. Currently it is very inconsistent not just between
modules but a lot of time inside a project too.

Imho:

We should simply adopt wicket's style (formatting + Save Actions) for the
whole wicketstuff project. Not because I like that style of formatting that
much (as every dev I also have a different opinion about The True Formatting
Rule :)) but it is consistent and wicket is the upstream project so
(probably) most of the wicketstuff commiters are used to it.

For js, xml, html, css files we should use the same indentation style as for
the java files. So in case we adopt wicket's style we should use tabs in
these files too.

We can add the eclipse prefs to git so it gets configured automatically. Do
not know how to do it for other IDE-s.

If we add this I do not think that we should reformat all projects at once.
Only to do it when we touch a project or file. A complete reformat could
make it harder to dig in the version history of the files.


Attila



[1] topic originally started here:
https://github.com/wicketstuff/core/commit/2d4ed55267cfee38fcdf33b89810edc048f766f1#comments

Reply via email to