Hi, I'm also +1 to format the code.
I think we should define the settings and do one big formatting commit. It is easy to see that the change is formatting without functional changes and ignore the changelist when looking in history. It is much harder to look for a functional change and it is inside a change that also formats the code. About .settings/ vs. maven-eclipse-plugin: I'm +1 for .settings/. I'm a user of m2eclipse (Eclipse) plugin and this one doesn't play nice together with maven-eclipse-plugin. And I think m2eclipse is much more powerful than m-e-p. martin-g On Thu, Apr 7, 2011 at 8:04 AM, Attila Király <kiralyattila...@gmail.com>wrote: > Hi! > > Starting this discussion because as it turned out there is a need among the > committers to establish a common code formatting in wicketstuff. [1] So > maybe it is time to have a bit of brainstorming about it. How to do it? > What > should it cover? What do you think? > > Having a common code formatting would ease the cross work between the > wicketstuff projects. Currently it is very inconsistent not just between > modules but a lot of time inside a project too. > > Imho: > > We should simply adopt wicket's style (formatting + Save Actions) for the > whole wicketstuff project. Not because I like that style of formatting that > much (as every dev I also have a different opinion about The True > Formatting > Rule :)) but it is consistent and wicket is the upstream project so > (probably) most of the wicketstuff commiters are used to it. > > For js, xml, html, css files we should use the same indentation style as > for > the java files. So in case we adopt wicket's style we should use tabs in > these files too. > > We can add the eclipse prefs to git so it gets configured automatically. Do > not know how to do it for other IDE-s. > > If we add this I do not think that we should reformat all projects at once. > Only to do it when we touch a project or file. A complete reformat could > make it harder to dig in the version history of the files. > > > Attila > > > > [1] topic originally started here: > > https://github.com/wicketstuff/core/commit/2d4ed55267cfee38fcdf33b89810edc048f766f1#comments > -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com <http://jweekend.com/>
