Wicket 6.x: https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/markup/repeater/RefreshingView.java#L81 Wicket 7.x: https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/markup/repeater/RefreshingView.java#L82
Since no one have asked for the change, I'd like to revert it to the version from 6.x Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Sun, Feb 22, 2015 at 3:18 PM, Tobias Soloschenko < [email protected]> wrote: > Hi, > > then I would suggest that the RefreshingView is going to make use of its > model if no items has been added - what do you think? > > On the other hand - if someone uses the internal model to put in some > additional information which are going to be retrieved in populateItem then > it would brake the usage. > > kind regards > > Tobias > > Am 22.02.15 um 14:07 schrieb Sven Meier: > > Hi, >> >> actually we can just change it to IModel<?>, since RefreshingView does >> not do anything with its model: there's no getter either and in Wicket no >> subclass uses its model. >> >> Regards >> Sven >> >> >> On 22.02.2015 13:43, Tobias Soloschenko wrote: >> >>> Hi, >>> >>> since the RefreshingView is iterating over each element and Iterable is >>> more flexible, I would prefer the new option. As far as I can see this >>> would change the signature but not let the users change their code, because >>> Collection also implements the Interface Iterable. The new signature would >>> make it easier to create a RefreshingView based on a keyset / values of a >>> Map - they return Iterable. >>> >>> In my opinion, I would say it makes sense to switch to Iterable. >>> >>> kind regards >>> >>> Tobias >>> >>> Am 22.02.15 um 11:32 schrieb Martijn Dashorst: >>> >>>> I'm working through our internal framework upgrading Wicket to 7. This >>>> is one place I think the Wicket API can improve further: >>>> >>>> Currently the constructor of RefreshingView is defined as: >>>> >>>> public RefreshingView(String id, IModel<? extends Collection<? >>>> extends T>> model) >>>> >>>> Probably the model can be better typed with IModel<? extends >>>> Iterable<? extends T>> >>>> >>>> WDYT? >>>> >>>> Martijn >>>> >>> >>> >> >
