Hi all,

apparently the change of RefreshingView slipped through with my changes for WICKET-5350.
I reverted the constructor argument to IModel<?>.

Have fun
Sven


On 22.02.2015 14:47, Andrea Del Bene wrote:
+1 for me to revert the change as Marting suggested. At the moment there is no reason to put such a constraint on model.
Having Iterable there makes sense only if it is used by Wicket as Tobias
suggested.
If we are going to introduce it then we have to make it clear how exactly the items from the passed Iterable are merged with the manually added ones.

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Sun, Feb 22, 2015 at 3:38 PM, Martijn Dashorst <
[email protected]> wrote:

On Sun, Feb 22, 2015 at 2:22 PM, Martin Grigorov <[email protected]>
wrote:
Wicket 6.x:

https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/markup/repeater/RefreshingView.java#L81
Wicket 7.x:

https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/markup/repeater/RefreshingView.java#L82
Since no one have asked for the change, I'd like to revert it to the
version from 6.x
that is also a possibility. I also don't mind having Iterable in there.

Martijn



Reply via email to