Hi,
code formatting is stored in org.eclipse.jdt.ui.prefs - but we no longer
have these files under version control since commit
2ab4c7c00d2207679c6a10d2aee8b7c5fd624ba3.
So +1 from me to remove the remaining settings. I see nothing of value
in there.
Sven
Am 04.03.2015 um 09:30 schrieb Martin Grigorov:
Hi Tobias,
I personally use Intellij IDEA and these files are in not in use by me.
But AFAIR the most useful feature in them is the code formatting rules. We
try to keep Wicket code formatted the same style. IMO this helps a lot in
maintenance. I personally get distracted when debugging something and see
code snippet that is wrongly formatted, or doesn't use braces, or something
similar.
I think I am the only user of IDEA in the team (except Peter Ertl, but he
is not very active lately) so I'm sure others will give their feedback on
this soon.
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Wed, Mar 4, 2015 at 9:50 AM, Tobias Soloschenko <
tobiassolosche...@googlemail.com> wrote:
Hi everyone,
I saw that there were several commits to .settings the last time and I
wondered why this folder is required in the repository anymore. Here is a
list of the files in a .settings folder (wicket/.settings)
https://github.com/apache/wicket/blob/master/.settings/org.eclipse.core.resources.prefs
https://github.com/apache/wicket/blob/master/.settings/org.eclipse.m2e.core.prefs
https://github.com/apache/wicket/blob/master/.settings/org.eclipse.pde.core.prefs
https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.common.component
https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.common.project.facet.core.xml
I think because maven is used to configure the projects we can remove those
files from the repository and configure it all in maven.
Encoding can be configured by (see
http://maven.apache.org/general.html#encoding-warning):
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
</properties>
Java Compile-Level can be configured with the compiler-plugin:
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.2</version>
<configuration>
<source>1.7</source>
<target>1.7</target>
</configuration>
</plugin>
</plugins>
The project facets are configured by "Maven Integration for Eclipse WTP"
and it receives the information of the web.xml and the packaging configured
in the pom (war/jar). It is preinstalled in Eclipse JEE. (see
http://marketplace.eclipse.org/node/96737)
The only entries to be custom configured are in
org.eclipse.core.resources.prefs containing .deprecations and I wonder if
they are required anymore.
The only thing to be done after importing the project into workspace is to
configure it as maven project. The .settings folder is created through the
m2e plugin based on the pom.xml, web.xml.
Did I overlook something?
What do you think?
kind regards
Tobias
