done: https://issues.apache.org/jira/browse/WICKET-5848
2015-03-04 12:19 GMT+01:00 Martin Grigorov <[email protected]>: > @Tobias: please file a ticket and assign it to Emond :-) > Or provide the PR yourself if you understand what > https://github.com/topicusonderwijs/m2e-settings does. > > Martin Grigorov > Wicket Training and Consulting > https://twitter.com/mtgrigorov > > On Wed, Mar 4, 2015 at 11:41 AM, Tobias Soloschenko < > [email protected]> wrote: > > > Good point to use a separate artifact, because users of IDEA do not > > require those settings - but as Martin mentioned it should be enforced > that > > eclipse user must run the configuration of that artifact to ensure the > code > > style. > > > > kind regards > > > > Tobias > > > > > Am 04.03.2015 um 10:28 schrieb Emond Papegaaij < > > [email protected]>: > > > > > > The maven-eclipse-plugin is not maintained at all. Everyone should use > > m2e. We > > > have developed an eclipse plugin to apply these settings automatically > > when > > > using m2e: > > > https://github.com/topicusonderwijs/m2e-settings > > > > > > I think we should create a wicket-eclipse-settings maven artifact and > use > > > that. > > > > > > Best regards, > > > Emond > > > > > >> On Wednesday 04 March 2015 10:09:31 Tobias Soloschenko wrote: > > >> Hi Martin, > > >> > > >> maybe we can use the maven-eclipse-plugin to apply formatting rules: > > >> > > >> > > > http://maven.apache.org/plugins/maven-eclipse-plugin/examples/load-code-styl > > >> es.html > > >> > > >> The plugin itself is not well maintained, but we only need to apply > the > > >> formatting rules to the IDE - I think on IDEA it is ignored, but we > > have to > > >> check it. > > >> > > >> Does this address your feature? > > >> > > >> kind regards > > >> > > >> Tobias > > >> > > >> 2015-03-04 9:30 GMT+01:00 Martin Grigorov <[email protected]>: > > >>> Hi Tobias, > > >>> > > >>> I personally use Intellij IDEA and these files are in not in use by > me. > > >>> But AFAIR the most useful feature in them is the code formatting > > rules. We > > >>> try to keep Wicket code formatted the same style. IMO this helps a > lot > > in > > >>> maintenance. I personally get distracted when debugging something and > > see > > >>> code snippet that is wrongly formatted, or doesn't use braces, or > > >>> something > > >>> similar. > > >>> > > >>> I think I am the only user of IDEA in the team (except Peter Ertl, > but > > he > > >>> is not very active lately) so I'm sure others will give their > feedback > > on > > >>> this soon. > > >>> > > >>> Martin Grigorov > > >>> Wicket Training and Consulting > > >>> https://twitter.com/mtgrigorov > > >>> > > >>> On Wed, Mar 4, 2015 at 9:50 AM, Tobias Soloschenko < > > >>> > > >>> [email protected]> wrote: > > >>>> Hi everyone, > > >>>> > > >>>> I saw that there were several commits to .settings the last time > and I > > >>>> wondered why this folder is required in the repository anymore. Here > > is > > >>>> a > > >>>> list of the files in a .settings folder (wicket/.settings) > > >>> > > >>> > > > https://github.com/apache/wicket/blob/master/.settings/org.eclipse.core.re > > >>> sources.prefs > > >>> > > >>> > > >>> > > > https://github.com/apache/wicket/blob/master/.settings/org.eclipse.m2e.cor > > >>> e.prefs > > >>> > > >>> > > >>> > > > https://github.com/apache/wicket/blob/master/.settings/org.eclipse.pde.cor > > >>> e.prefs > > >>> > > >>> > > >>> > > > https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.com > > >>> mon.component > > >>> > > >>> > > >>> > > > https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.com > > >>> mon.project.facet.core.xml> > > >>>> I think because maven is used to configure the projects we can > remove > > >>> > > >>> those > > >>> > > >>>> files from the repository and configure it all in maven. > > >>>> > > >>>> Encoding can be configured by (see > > >>>> http://maven.apache.org/general.html#encoding-warning): > > >>>> > > >>>> <properties> > > >>>> > > >>>> > <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> > > >>> > > >>> > > > <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> > > >>> > > >>>> </properties> > > >>>> > > >>>> Java Compile-Level can be configured with the compiler-plugin: > > >>>> <plugins> > > >>>> > > >>>> <plugin> > > >>>> > > >>>> <groupId>org.apache.maven.plugins</groupId> > > >>>> <artifactId>maven-compiler-plugin</artifactId> > > >>>> <version>3.2</version> > > >>>> <configuration> > > >>>> > > >>>> <source>1.7</source> > > >>>> <target>1.7</target> > > >>>> > > >>>> </configuration> > > >>>> > > >>>> </plugin> > > >>>> > > >>>> </plugins> > > >>>> > > >>>> The project facets are configured by "Maven Integration for Eclipse > > WTP" > > >>>> and it receives the information of the web.xml and the packaging > > >>> > > >>> configured > > >>> > > >>>> in the pom (war/jar). It is preinstalled in Eclipse JEE. (see > > >>>> http://marketplace.eclipse.org/node/96737) > > >>>> > > >>>> The only entries to be custom configured are in > > >>>> org.eclipse.core.resources.prefs containing .deprecations and I > wonder > > >>>> if > > >>>> they are required anymore. > > >>>> > > >>>> The only thing to be done after importing the project into workspace > > is > > >>> > > >>> to > > >>> > > >>>> configure it as maven project. The .settings folder is created > through > > >>> > > >>> the > > >>> > > >>>> m2e plugin based on the pom.xml, web.xml. > > >>>> > > >>>> Did I overlook something? > > >>>> > > >>>> What do you think? > > >>>> > > >>>> kind regards > > >>>> > > >>>> Tobias > > > > > >
