Andrea, Please make the changes and we can discuss the diff after that.
Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Mon, May 25, 2015 at 7:15 AM, Tobias Soloschenko < [email protected]> wrote: > Woops, I send the mail to fast - just wanted to add that if this is ok > then I would accept adding this constructor and the method. > > This would reduce the overhead of source code for those usecases. > > kind regards > > Tobias > > Am 24.05.15 um 21:17 schrieb Andrea Del Bene: > >> yes, sorry for my 'creative' writing :) >> >> On 24 May 2015 20:42, "Martin Grigorov" <[email protected]> wrote: >> >> Hi Andrea, >>> >>> Do you talk about StringResourceModel? >>> On May 24, 2015 6:21 PM, "Andrea Del Bene" <[email protected]> wrote: >>> >>> Hi, >>>> >>>> I'd like to apply the two following improvements: >>>> >>>> -add a setDefaultValue(String value) to not force users to create a >>>> model >>>> for static values >>>> -add constructor StrngResourceLocator(String resourceKey, IModel<?> >>>> model). (Has it been removed on purpose?) >>>> >>>> What do you think? >>>> >>>> >
