Look good to me. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov
On Mon, May 25, 2015 at 1:16 PM, andrea del bene <an.delb...@gmail.com> wrote: > Here it is... > > > https://git1-us-west.apache.org/repos/asf?p=wicket.git;a=commitdiff;h=b680969d;hp=91f2f8a24d8342fc484ca7d2869a401079707855 > > > On 25/05/2015 09:09, Martin Grigorov wrote: > >> Andrea, >> >> Please make the changes and we can discuss the diff after that. >> >> Martin Grigorov >> Wicket Training and Consulting >> https://twitter.com/mtgrigorov >> >> On Mon, May 25, 2015 at 7:15 AM, Tobias Soloschenko < >> tobiassolosche...@googlemail.com> wrote: >> >> Woops, I send the mail to fast - just wanted to add that if this is ok >>> then I would accept adding this constructor and the method. >>> >>> This would reduce the overhead of source code for those usecases. >>> >>> kind regards >>> >>> Tobias >>> >>> Am 24.05.15 um 21:17 schrieb Andrea Del Bene: >>> >>> yes, sorry for my 'creative' writing :) >>>> >>>> On 24 May 2015 20:42, "Martin Grigorov" <mgrigo...@apache.org> wrote: >>>> >>>> Hi Andrea, >>>> >>>>> Do you talk about StringResourceModel? >>>>> On May 24, 2015 6:21 PM, "Andrea Del Bene" <an.delb...@gmail.com> >>>>> wrote: >>>>> >>>>> Hi, >>>>> >>>>>> I'd like to apply the two following improvements: >>>>>> >>>>>> -add a setDefaultValue(String value) to not force users to create a >>>>>> model >>>>>> for static values >>>>>> -add constructor StrngResourceLocator(String resourceKey, IModel<?> >>>>>> model). (Has it been removed on purpose?) >>>>>> >>>>>> What do you think? >>>>>> >>>>>> >>>>>> >
