[GitHub] wicket pull request #253: WICKET-6498 deferred javascript

[solomax]

Github user solomax commented on a diff in the pull request:

    https://github.com/apache/wicket/pull/253#discussion_r161151470
  
    --- Diff: 
wicket-core/src/main/java/org/apache/wicket/markup/head/OnDomReadyHeaderItem.java
 ---
    @@ -86,8 +86,8 @@ public void render(Response response)
                CharSequence js = getJavaScript();
                if (Strings.isEmpty(js) == false)
                {
    -                   JavaScriptUtils.writeJavaScript(response, 
"Wicket.Event.add(window, \"domready\", " +
    -                           "function(event) { " + js + ";});");
    +                   JavaScriptUtils.writeJavaScript(response,
    +                           "var f = function() {" + js + ";};\nif 
('loading' !== document.readyState) f(); else 
document.addEventListener('DOMContentLoaded', f);");
    --- End diff --
    
    I would like to change this code to be:
    ```
    { //scope
        const f = function() {" + js + ";}; ....
    }
    ```
    
    This way multiple `OnDomReadyHeader` items will work as expected in 
deferred mode
    WDYT?


---