Github user solomax commented on a diff in the pull request:

    https://github.com/apache/wicket/pull/253#discussion_r161372957
  
    --- Diff: 
wicket-core/src/main/java/org/apache/wicket/markup/head/filter/FilteringHeaderResponse.java
 ---
    @@ -263,14 +262,12 @@ public void markRendered(Object object)
                        }
                };
     
    -           ResourceAggregator resourceAggregator = new 
ResourceAggregator(headerRenderer);
    -
                for (HeaderItem curItem : resp)
                {
    -                   resourceAggregator.render(curItem);
    +                   headerRenderer.render(curItem);
    --- End diff --
    
    Unfortunately with this change `FilteringHeaderResponseTest` fails due to 
JS dependencies are not being rendered :(((
    @svenmeier Could you please take a look at this?


---

Reply via email to