Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/253#discussion_r161151287
--- Diff:
wicket-core/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java
---
@@ -106,8 +107,7 @@ public void renderHead(final Component component, final
IHeaderResponse response
RequestCycle requestCycle = component.getRequestCycle();
Url baseUrl = requestCycle.getUrlRenderer().getBaseUrl();
CharSequence ajaxBaseUrl =
Strings.escapeMarkup(baseUrl.toString());
-
response.render(JavaScriptHeaderItem.forScript("Wicket.Ajax.baseUrl=\"" +
ajaxBaseUrl
- + "\";", "wicket-ajax-base-url"));
--- End diff --
previous code set the id attribute, so the check was trivial (node.attr ===
'wicket-ajax-base-url'). Current implementation adds text content. which have
to be parsed, maybe it worth to set attribute back to avoid parsing the text?
---
