I would support any decision here :) >From my point of view app with in-build "memory leak" shouldn't be generated. Generated quick-start project is being owned by the user. And he/she can choose any license :) We can add NOTICE to generated project, not sure if this is required .....
On Sun, Jan 14, 2018 at 11:30 AM, Tobias Soloschenko <tobiassolosche...@googlemail.com> wrote: > I would also not enforce user to take a LGPL dependency. For Log4j you can > use SLF4J adapter and also logback if you finally want to but you don’t have > to. > > +1 to revert. > > kind regards > > Tobias > >> Am 14.01.2018 um 04:45 schrieb Maxim Solodovnik <solomax...@gmail.com>: >> >> Actually it is not being distributed :) >> It is in the pom only, It only "distributed" after final project, >> generated on client side, is being built >> Should I add reference to NOTICE file? >> >> On Sun, Jan 14, 2018 at 4:08 AM, Martijn Dashorst >> <martijn.dasho...@gmail.com> wrote: >>> Please note that logback is LGPL 2.1/EPL licensed. >>> >>> LGPL 2.1 cannot be distributed with our code. EPL only as binary, and >>> properly attributed in the NOTICE file: >>> >>> https://www.apache.org/legal/resolved.html#category-b >>> >>> Martijn >>> >>> >>>> On Sat, Jan 13, 2018 at 4:20 AM, solomax <g...@git.apache.org> wrote: >>>> GitHub user solomax opened a pull request: >>>> >>>> https://github.com/apache/wicket/pull/257 >>>> >>>> [WICKET-6518] Log4j is replaced with logback >>>> >>>> >>>> >>>> You can merge this pull request into a Git repository by running: >>>> >>>> $ git pull https://github.com/apache/wicket >>>> WICKET-6518-quickstart-logback >>>> >>>> Alternatively you can review and apply these changes as the patch at: >>>> >>>> https://github.com/apache/wicket/pull/257.patch >>>> >>>> To close this pull request, make a commit to your master/trunk branch >>>> with (at least) the following in the commit message: >>>> >>>> This closes #257 >>>> >>>> ---- >>>> commit cfd6a55fc9d613d4412a004efcc8e06d6ac1d73d >>>> Author: Maxim Solodovnik <solomax666@...> >>>> Date: 2018-01-13T03:18:56Z >>>> >>>> [WICKET-6518] Log4j is replaced with logback >>>> >>>> ---- >>>> >>>> >>>> --- >>> >>> >>> >>> -- >>> Become a Wicket expert, learn from the best: http://wicketinaction.com >> >> >> >> -- >> WBR >> Maxim aka solomax -- WBR Maxim aka solomax
