So you suggest to add JUL / Log4j without logging.properties / log4j.xml ? If this is what you propose then it won't be a complete quickstart because the users will have to add additional files to have a complete setup. In the PR you can see that there is log4j.xml that is being replaced with logback.xml.
On Sun, Jan 14, 2018 at 1:09 PM, Tobias Soloschenko < tobiassolosche...@googlemail.com> wrote: > My point was to include something which can be included in every setup. > Example: If you use log4j or juls or other logging - you can simply use > this logging or add the SLF4J adapter and even add logback, but you don’t > need to remove something like a logback xml. > > Hope this makes it more clear. > > kind regards > > Tobias > > > Am 14.01.2018 um 12:30 schrieb Maxim Solodovnik <solomax...@gmail.com>: > > > > Thanks Martin :) > > This was exactly my point :) > > > > WBR, Maxim > > (from mobile, sorry for the typos) > > > >> On Sun, Jan 14, 2018, 18:29 Martin Grigorov <mgrigo...@apache.org> > wrote: > >> > >> I do not see any problem here. > >> We do not distribute any non-ASL2 code or binaries! > >> The snippet in pom.xml and logback.xml are ASL2 as being part of > >> wicket-archetype-quickstart, so the user can do anything with them, > >> including replacing them with whatever (s)he finds better. > >> > >> Actually I believe Logback is far more used than Log4j in business > >> applications. > >> > >> "Promoting" JUL would be the worst we can do. > >> > >> On Sun, Jan 14, 2018 at 10:34 AM, Maxim Solodovnik < > solomax...@gmail.com> > >> wrote: > >> > >>> EPL is compatible with APLv2, just need to be added to NOTICE. > >>> I mean the files we are distributing doesn't contain any binaries. > >>> > >>> Logback binaries appears only after compilation of generated > >>> quick-start .... nothing illegal. > >>> > >>> Will check java util logging in the beginning of next week .... > >>> > >>> On Sun, Jan 14, 2018 at 4:28 PM, Tobias Soloschenko > >>> <tobiassolosche...@googlemail.com> wrote: > >>>> What do you mean by choose any license? > >>>> > >>>> If you put in the logback xml it is required to add the logback > >>> dependency to enable the logging - logback is EPL / LGPL so it is > >>> incompatible to Apache license v2. > >>>> > >>>> So the user is required to remove everything first and add a logging > >>> with MIT or any other non-restrict license. > >>>> > >>>> To generate something with a restricted license is also not the target > >>> solution we should go for. > >>>> > >>>> What about java utils logging? SLF4J has also an adapter for this and > >>> maybe we can prevent the memory leak by this. > >>>> > >>>> kind regards > >>>> > >>>> Tobias > >>>> > >>>>> Am 14.01.2018 um 05:58 schrieb Maxim Solodovnik < > solomax...@gmail.com > >>> : > >>>>> > >>>>> I would support any decision here :) > >>>>> > >>>>> From my point of view app with in-build "memory leak" shouldn't be > >>> generated. > >>>>> Generated quick-start project is being owned by the user. And he/she > >>>>> can choose any license :) > >>>>> We can add NOTICE to generated project, not sure if this is required > >>> ..... > >>>>> > >>>>> On Sun, Jan 14, 2018 at 11:30 AM, Tobias Soloschenko > >>>>> <tobiassolosche...@googlemail.com> wrote: > >>>>>> I would also not enforce user to take a LGPL dependency. For Log4j > >> you > >>> can use SLF4J adapter and also logback if you finally want to but you > >> don’t > >>> have to. > >>>>>> > >>>>>> +1 to revert. > >>>>>> > >>>>>> kind regards > >>>>>> > >>>>>> Tobias > >>>>>> > >>>>>>> Am 14.01.2018 um 04:45 schrieb Maxim Solodovnik < > >> solomax...@gmail.com > >>>> : > >>>>>>> > >>>>>>> Actually it is not being distributed :) > >>>>>>> It is in the pom only, It only "distributed" after final project, > >>>>>>> generated on client side, is being built > >>>>>>> Should I add reference to NOTICE file? > >>>>>>> > >>>>>>> On Sun, Jan 14, 2018 at 4:08 AM, Martijn Dashorst > >>>>>>> <martijn.dasho...@gmail.com> wrote: > >>>>>>>> Please note that logback is LGPL 2.1/EPL licensed. > >>>>>>>> > >>>>>>>> LGPL 2.1 cannot be distributed with our code. EPL only as binary, > >> and > >>>>>>>> properly attributed in the NOTICE file: > >>>>>>>> > >>>>>>>> https://www.apache.org/legal/resolved.html#category-b > >>>>>>>> > >>>>>>>> Martijn > >>>>>>>> > >>>>>>>> > >>>>>>>>> On Sat, Jan 13, 2018 at 4:20 AM, solomax <g...@git.apache.org> > >>> wrote: > >>>>>>>>> GitHub user solomax opened a pull request: > >>>>>>>>> > >>>>>>>>> https://github.com/apache/wicket/pull/257 > >>>>>>>>> > >>>>>>>>> [WICKET-6518] Log4j is replaced with logback > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> You can merge this pull request into a Git repository by running: > >>>>>>>>> > >>>>>>>>> $ git pull https://github.com/apache/wicket > >>> WICKET-6518-quickstart-logback > >>>>>>>>> > >>>>>>>>> Alternatively you can review and apply these changes as the patch > >>> at: > >>>>>>>>> > >>>>>>>>> https://github.com/apache/wicket/pull/257.patch > >>>>>>>>> > >>>>>>>>> To close this pull request, make a commit to your master/trunk > >>> branch > >>>>>>>>> with (at least) the following in the commit message: > >>>>>>>>> > >>>>>>>>> This closes #257 > >>>>>>>>> > >>>>>>>>> ---- > >>>>>>>>> commit cfd6a55fc9d613d4412a004efcc8e06d6ac1d73d > >>>>>>>>> Author: Maxim Solodovnik <solomax666@...> > >>>>>>>>> Date: 2018-01-13T03:18:56Z > >>>>>>>>> > >>>>>>>>> [WICKET-6518] Log4j is replaced with logback > >>>>>>>>> > >>>>>>>>> ---- > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> --- > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> -- > >>>>>>>> Become a Wicket expert, learn from the best: > >>> http://wicketinaction.com > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> -- > >>>>>>> WBR > >>>>>>> Maxim aka solomax > >>>>> > >>>>> > >>>>> > >>>>> -- > >>>>> WBR > >>>>> Maxim aka solomax > >>> > >>> > >>> > >>> -- > >>> WBR > >>> Maxim aka solomax > >>> > >> >
