I would start the VOTE on 9.13.0 without WICKET-7033 It seems to be big enough for last minute fix IMO better to release, then add it without rush :)
On Thu, 13 Apr 2023 at 19:31, Ernesto Reinaldo Barreiro <reier...@gmail.com> wrote: > > Hi, > > I also worked on this: uploading to a resource + adapt the progress upload > to work for such use case > > https://github.com/apache/wicket/pull/571 > > https://issues.apache.org/jira/browse/WICKET-7033 > > This seems to be working. Not sure if this needs more work and if it is > better to leave this for 9.14.x? This needs to be potted to master 10.x > (which should not be difficult) > > > On Wed, Apr 12, 2023 at 4:27 AM Maxim Solodovnik <solomax...@gmail.com> > wrote: > > > This one https://issues.apache.org/jira/browse/WICKET-7044 > > > > Also meed to be addressed > > I'll try to take a look ASAP > > > > from mobile (sorry for typos ;) > > > > > > On Wed, Apr 12, 2023, 01:07 Thomas Heigl <tho...@umschalt.com> wrote: > > > > > I have backported the two improvements to 9.x. Thanks a lot for letting > > me > > > include these two PRs. > > > > > > We can continue with the release. > > > > > > On Tue, Apr 11, 2023 at 10:57 AM Andrea Del Bene <an.delb...@gmail.com> > > > wrote: > > > > > > > On Tue, Apr 11, 2023 at 8:38 AM Ernesto Reinaldo Barreiro < > > > > reier...@gmail.com> wrote: > > > > > > > > > Many thanks for this. For us it will be fine if we can get a new > > > version > > > > of > > > > > wicket by the end of this week. > > > > > > > > > > > > > 👍 I agree ! this vote is cancelled > > > > > > > > > > > > > > > > > > On Tue, Apr 11, 2023 at 9:07 AM Thomas Heigl <tho...@umschalt.com> > > > > wrote: > > > > > > > > > > > I have one more small optimization: > > > > > > https://github.com/apache/wicket/pull/573 > > > > > > > > > > > > There are many more potential allocation improvements but those two > > > are > > > > > the > > > > > > lowest hanging fruit. > > > > > > > > > > > > On Tue, Apr 11, 2023 at 7:31 AM Maxim Solodovnik < > > > solomax...@gmail.com > > > > > > > > > > > wrote: > > > > > > > > > > > > > +1 to restart the VOTE with this optimization included :) > > > > > > > > > > > > > > On Mon, 10 Apr 2023 at 22:29, Thomas Heigl <tho...@umschalt.com> > > > > > wrote: > > > > > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > > > I know I'm a bit late, but I just discovered a way to reduce a > > > ton > > > > of > > > > > > > > allocations in our application: > > > > > > > > > > > > > > > > https://github.com/apache/wicket/pull/572 > > > > > > > > https://issues.apache.org/jira/browse/WICKET-7041 > > > > > > > > > > > > > > > > Any chance we can wait for this change? The implementation is > > > > trivial > > > > > > and > > > > > > > > should reduce allocations for pretty much all users of Wicket. > > > > > > > > We just have to decide if we make the optimization the default > > > for > > > > > all > > > > > > > > `StringResponse`s or apply it case-by-case. > > > > > > > > > > > > > > > > Best, > > > > > > > > > > > > > > > > Thomas > > > > > > > > > > > > > > > > > > > > > > > > On Mon, Apr 10, 2023 at 8:55 AM Maxim Solodovnik < > > > > > solomax...@gmail.com > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > > > > > Tested: > > > > > > > > > - signarures > > > > > > > > > - build from sources > > > > > > > > > - wicketstuff build > > > > > > > > > - our main app build and manual tests > > > > > > > > > > > > > > > > > > On Sat, 8 Apr 2023 at 13:37, Ernesto Reinaldo Barreiro > > > > > > > > > <reier...@gmail.com> wrote: > > > > > > > > > > > > > > > > > > > > Many thanks for starting a vote! > > > > > > > > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > > > > > > > On Fri, Apr 7, 2023 at 11:07 PM Andrea Del Bene < > > > > > > > an.delb...@gmail.com> > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > This is a vote to release Apache Wicket 9.13.0 > > > > > > > > > > > > > > > > > > > > > > Please download the source distributions found in our > > > staging > > > > > > area > > > > > > > > > > > linked below. > > > > > > > > > > > > > > > > > > > > > > I have included the signatures for both the source > > > archives. > > > > > This > > > > > > > vote > > > > > > > > > > > lasts for 72 hours minimum. > > > > > > > > > > > > > > > > > > > > > > [ ] Yes, release Apache Wicket 9.13.0 > > > > > > > > > > > [ ] No, don't release Apache Wicket 9.13.0, because ... > > > > > > > > > > > > > > > > > > > > > > Distributions, changelog, keys and signatures can be > > found > > > > at: > > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/wicket/9.13.0 > > > > > > > > > > > > > > > > > > > > > > Staging repository: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachewicket-1178/ > > > > > > > > > > > > > > > > > > > > > > The binaries are available in the above link, as are a > > > > staging > > > > > > > > > > > repository for Maven. Typically the vote is on the > > source, > > > > but > > > > > > > should > > > > > > > > > > > you find a problem with one of the binaries, please let > > me > > > > > know, > > > > > > I > > > > > > > can > > > > > > > > > > > re-roll them some way or the other. > > > > > > > > > > > > > > > > > > > > > > Staging git repository data: > > > > > > > > > > > > > > > > > > > > > > Repository: g...@github.com:bitstorm/wicket.git > > > > > > > > > > > Branch: build/wicket-9.13.0 > > > > > > > > > > > Release tag: rel/wicket-9.13.0 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ======================================================================== > > > > > > > > > > > > > > > > > > > > > > CHANGELOG for 9.13.0: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ** Bug > > > > > > > > > > > > > > > > > > > > > > * [WICKET-7005] - ByteBuddy IllegalStateException: > > > > Cannot > > > > > > > inject > > > > > > > > > > > already loaded type > > > > > > > > > > > * [WICKET-7022] - JavaScriptStripper fails to detect > > > > > regular > > > > > > > > > > > expression correctly > > > > > > > > > > > * [WICKET-7028] - CSP header not rendered when using > > > > > > > > > > > RedirectPolicy.NEVER_REDIRECT > > > > > > > > > > > * [WICKET-7034] - WebSocket.Closed event not fired > > > when > > > > > > error > > > > > > > > > occurred > > > > > > > > > > > * [WICKET-7037] - [Ajax Download] cookie used to > > track > > > > > > > download > > > > > > > > > > > complete misses the SameSite attribute > > > > > > > > > > > > > > > > > > > > > > ** Improvement > > > > > > > > > > > > > > > > > > > > > > * [WICKET-7011] - Improve usage of JUnit 5.x APIs > > > > > > > > > > > * [WICKET-7014] - Use new API for forward > > > compatibility > > > > > with > > > > > > > CDI 4 > > > > > > > > > > > * [WICKET-7016] - Support GCM-SIV for page store > > > > > encryption > > > > > > > > > > > * [WICKET-7017] - ListenerRequestHandler should not > > > hide > > > > > > > > > > > IndexOutOfBoundsException > > > > > > > > > > > * [WICKET-7021] - Additional OSGi import fixes > > > > > > > > > > > * [WICKET-7025] - Package private methods should be > > > > > proxied > > > > > > by > > > > > > > > > > > ByteBuddy > > > > > > > > > > > * [WICKET-7031] - Update to JQuery 3.6.4 > > > > > > > > > > > * [WICKET-7032] - Update the JS tests to use latest > > > > > version > > > > > > of > > > > > > > > > > > QUnit (2.x) > > > > > > > > > > > * [WICKET-7035] - fileCountMax should be added to > > > > control > > > > > > the > > > > > > > > > > > amount of files being uploaded > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > Regards - Ernesto Reinaldo Barreiro > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > Best regards, > > > > > > > > > Maxim > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > Best regards, > > > > > > > Maxim > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Regards - Ernesto Reinaldo Barreiro > > > > > > > > > > > > > > > > > -- > > > > Andrea Del Bene. > > > > Apache Wicket committer. > > > > > > > > > > > > -- > Regards - Ernesto Reinaldo Barreiro -- Best regards, Maxim
