Hi Dhanuka, I noticed few issues in pom.xml of this orbit bundle.
1) Import package section is empty. Please the put correct import package list. 2) Optional=true is missing from some of the dependencies. 3) Following third-party libraries have been embedded inside this orbit bundle netty metrics-core guava jackson-core-as |jackson-mapper-asl slf4j-api slf4j-log4j12 *apache-cassandra* libthrift; 4) Size of this bundle is around 8.5 MB and all the above embedded dependencies has contributed to this size. I know there exists orbit bundles with such issues, but we've started this effort recently to verify all the new orbit bundles before publishing them to nexus repository. I am rejecting this pull request. Please fix these issues and send the PR again. Thanks, Sameera. On Fri, Oct 3, 2014 at 9:37 PM, Dhanuka Ranasinghe <dhan...@wso2.com> wrote: > Hi, > > I don't have permission to merge below pull request, I guess some one who > has permission would need to attend this. > > https://github.com/wso2/orbit/pull/26 > > Cheers, > Dhanuka > > *Dhanuka Ranasinghe* > > Senior Software Engineer > WSO2 Inc. ; http://wso2.com > lean . enterprise . middleware > > phone : +94 715381915 > > On Fri, Oct 3, 2014 at 6:31 PM, Harsha Kumara <hars...@wso2.com> wrote: > >> Adding Maheshika. >> >> On Fri, Oct 3, 2014 at 6:23 PM, Asanka Abeyweera <asank...@wso2.com> >> wrote: >> >>> Hi all, >>> >>> I created a pull request [1] in wso2/orbit removing the parent pom >>> reference in cql-driver bundle. Can we release this as >>> cql-driver-1.0.5.wso2v2 in wso2/orbit? >>> >>> [1] https://github.com/wso2/orbit/pull/26 >>> >>> >>> On Fri, Oct 3, 2014 at 6:17 PM, Asitha Nanayakkara <asi...@wso2.com> >>> wrote: >>> >>>> Hi everyone, >>>> >>>> Since the issue is a blocker for us we are making the versions >>>> consistent throughout the platform by using the existing cql-driver. >>>> Changes needed in carbon-storage-management is complete. >>>> >>>> @PrabathA: Please review and merge the pull request >>>> https://github.com/wso2-dev/carbon-storage-management/pull/48 >>>> >>>> Thank you. >>>> >>>> On Thu, Oct 2, 2014 at 7:37 AM, Prabath Abeysekera <praba...@wso2.com> >>>> wrote: >>>> >>>>> Hi Everyone, >>>>> >>>>> AsankaAB and Asitha have finally found the root cause of this issue. >>>>> Excellent stuff guys! >>>>> >>>>> It appears as if a few different versions of transitive dependencies >>>>> (i.e guava) used within some of the libraries resulted in the package >>>>> conflicts observed. As for the resolutions available, we'd have to make >>>>> the >>>>> versions of the aforesaid libraries that are being used in other >>>>> dependencies consistent across the platform. This is currently being >>>>> worked >>>>> on and We'll be updating the thread once done. >>>>> >>>>> Cheers, >>>>> Prabath >>>>> >>>>> On Wed, Oct 1, 2014 at 5:29 PM, Asitha Nanayakkara <asi...@wso2.com> >>>>> wrote: >>>>> >>>>>> adding dev list >>>>>> >>>>>> On Wed, Oct 1, 2014 at 9:36 AM, Asanka Abeyweera <asank...@wso2.com> >>>>>> wrote: >>>>>> >>>>>>> Hi Asitha/Prabath, >>>>>>> >>>>>>> The issue is seems to be a side effect of the switch we made from >>>>>>> cql-driver to cassandra-driver-core. I reverted back to cql-driver and >>>>>>> the >>>>>>> issue does not occur after that. Therefore I think the issue is with >>>>>>> cassandra-driver-core bundle. >>>>>>> >>>>>>> Since we use the "org.wso2.carbon.cassandra.datareader.feature" >>>>>>> which uses cassandra-driver-core, we cannot switch completely to >>>>>>> cql-driver >>>>>>> until the datareader feature also revert back to cql-driver. What do you >>>>>>> think we should do to resolve this issue? >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Wed, Oct 1, 2014 at 5:44 AM, Prabath Abeysekera < >>>>>>> praba...@wso2.com> wrote: >>>>>>> >>>>>>>> Most probably the proper initialization of the data-source >>>>>>>> component was interrupted as a result of some issue it was hit with >>>>>>>> while >>>>>>>> trying to register "CassandraDaraReader". This might have further gone >>>>>>>> on >>>>>>>> to block the process of making the data-sources configured in the >>>>>>>> master-datasources.xml JNDI bound, causing the reported problem. >>>>>>>> >>>>>>>> Why don't you boot up the server with OSGi debugging mode on and >>>>>>>> see what's gone wrong? In the meantime, I too will give it a try and >>>>>>>> see if >>>>>>>> I can get this reproduced locally. >>>>>>>> >>>>>>>> Cheers, >>>>>>>> Pravatg >>>>>>>> >>>>>>>> On Tue, Sep 30, 2014 at 2:49 PM, Asitha Nanayakkara < >>>>>>>> asi...@wso2.com> wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> When I add >>>>>>>>> org.wso2.carbon.cassandra.datareader.datasource.CassandraDataSourceReader >>>>>>>>> to the providers list of master-datasources.xml I get an error[1] >>>>>>>>> initialising User Manager Core Bundle due to failure to lookup >>>>>>>>> jdbc/WSO2CarbonDB entry in master-datasources.xml. >>>>>>>>> >>>>>>>>> When the CassandraDataSourceReader is removed from providers this >>>>>>>>> doesn't happen. Due to this we can't connect an external Cassandra >>>>>>>>> data >>>>>>>>> source for MB. This is a blocker for WSO2 MB 3.0.0 M1 release. (This >>>>>>>>> worked >>>>>>>>> fine earlier) >>>>>>>>> >>>>>>>>> Any idea why this is happening? >>>>>>>>> >>>>>>>>> >>>>>>>>> [1] >>>>>>>>> ERROR {org.wso2.carbon.user.core.internal.Activator} - Cannot >>>>>>>>> start User Manager Core bundle >>>>>>>>> java.lang.RuntimeException: Error in looking up data source: Name >>>>>>>>> [jdbc/WSO2CarbonDB] is not bound in this Context. Unable to find >>>>>>>>> [jdbc]. >>>>>>>>> at >>>>>>>>> org.wso2.carbon.user.core.util.DatabaseUtil.lookupDataSource(DatabaseUtil.java:86) >>>>>>>>> at >>>>>>>>> org.wso2.carbon.user.core.util.DatabaseUtil.createRealmDataSource(DatabaseUtil.java:172) >>>>>>>>> at >>>>>>>>> org.wso2.carbon.user.core.util.DatabaseUtil.getRealmDataSource(DatabaseUtil.java:66) >>>>>>>>> at >>>>>>>>> org.wso2.carbon.user.core.common.DefaultRealmService.<init>(DefaultRealmService.java:89) >>>>>>>>> at >>>>>>>>> org.wso2.carbon.user.core.common.DefaultRealmService.<init>(DefaultRealmService.java:114) >>>>>>>>> at >>>>>>>>> org.wso2.carbon.user.core.internal.Activator.startDeploy(Activator.java:69) >>>>>>>>> at >>>>>>>>> org.wso2.carbon.user.core.internal.BundleCheckActivator.start(BundleCheckActivator.java:61) >>>>>>>>> at >>>>>>>>> org.eclipse.osgi.framework.internal.core.BundleContextImpl$1.run(BundleContextImpl.java:711) >>>>>>>>> at java.security.AccessController.doPrivileged(Native Method) >>>>>>>>> at >>>>>>>>> org.eclipse.osgi.framework.internal.core.BundleContextImpl.startActivator(BundleContextImpl.java:702) >>>>>>>>> at >>>>>>>>> org.eclipse.osgi.framework.internal.core.BundleContextImpl.start(BundleContextImpl.java:683) >>>>>>>>> at >>>>>>>>> org.eclipse.osgi.framework.internal.core.BundleHost.startWorker(BundleHost.java:381) >>>>>>>>> at >>>>>>>>> org.eclipse.osgi.framework.internal.core.AbstractBundle.resume(AbstractBundle.java:390) >>>>>>>>> at >>>>>>>>> org.eclipse.osgi.framework.internal.core.Framework.resumeBundle(Framework.java:1176) >>>>>>>>> at >>>>>>>>> org.eclipse.osgi.framework.internal.core.StartLevelManager.resumeBundles(StartLevelManager.java:559) >>>>>>>>> at >>>>>>>>> org.eclipse.osgi.framework.internal.core.StartLevelManager.resumeBundles(StartLevelManager.java:544) >>>>>>>>> at >>>>>>>>> org.eclipse.osgi.framework.internal.core.StartLevelManager.incFWSL(StartLevelManager.java:457) >>>>>>>>> at >>>>>>>>> org.eclipse.osgi.framework.internal.core.StartLevelManager.doSetStartLevel(StartLevelManager.java:243) >>>>>>>>> at >>>>>>>>> org.eclipse.osgi.framework.internal.core.StartLevelManager.dispatchEvent(StartLevelManager.java:438) >>>>>>>>> at >>>>>>>>> org.eclipse.osgi.framework.internal.core.StartLevelManager.dispatchEvent(StartLevelManager.java:1) >>>>>>>>> at >>>>>>>>> org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230) >>>>>>>>> at >>>>>>>>> org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340) >>>>>>>>> Caused by: javax.naming.NameNotFoundException: Name >>>>>>>>> [jdbc/WSO2CarbonDB] is not bound in this Context. Unable to find >>>>>>>>> [jdbc]. >>>>>>>>> at org.apache.naming.NamingContext.lookup(NamingContext.java:819) >>>>>>>>> at org.apache.naming.NamingContext.lookup(NamingContext.java:167) >>>>>>>>> at >>>>>>>>> org.wso2.carbon.context.internal.CarbonContextDataHolder$CarbonInitialJNDIContext.lookup(CarbonContextDataHolder.java:705) >>>>>>>>> at javax.naming.InitialContext.lookup(InitialContext.java:411) >>>>>>>>> at javax.naming.InitialContext.doLookup(InitialContext.java:284) >>>>>>>>> at >>>>>>>>> org.wso2.carbon.user.core.util.DatabaseUtil.lookupDataSource(DatabaseUtil.java:84) >>>>>>>>> ... 21 more >>>>>>>>> >>>>>>>>> Thanks. >>>>>>>>> -- >>>>>>>>> *Asitha Nanayakkara* >>>>>>>>> Software Engineer >>>>>>>>> WSO2, Inc. http://wso2.com/ >>>>>>>>> Mob: + 94 77 85 30 682 >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Prabath Abeysekara >>>>>>>> Associate Technical Lead, Data TG. >>>>>>>> WSO2 Inc. >>>>>>>> Email: praba...@wso2.com >>>>>>>> Mobile: +94774171471 >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Asanka Abeyweera >>>>>>> Software Engineer >>>>>>> WSO2 Inc. >>>>>>> >>>>>>> Phone: +94 712228648 >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> *Asitha Nanayakkara* >>>>>> Software Engineer >>>>>> WSO2, Inc. http://wso2.com/ >>>>>> Mob: + 94 77 85 30 682 >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Prabath Abeysekara >>>>> Associate Technical Lead, Data TG. >>>>> WSO2 Inc. >>>>> Email: praba...@wso2.com >>>>> Mobile: +94774171471 >>>>> >>>> >>>> >>>> >>>> -- >>>> *Asitha Nanayakkara* >>>> Software Engineer >>>> WSO2, Inc. http://wso2.com/ >>>> Mob: + 94 77 85 30 682 >>>> >>>> >>> >>> >>> -- >>> Asanka Abeyweera >>> Software Engineer >>> WSO2 Inc. >>> >>> Phone: +94 712228648 >>> >>> _______________________________________________ >>> Dev mailing list >>> Dev@wso2.org >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> Harsha Kumara >> Software Engineer, WSO2 Inc. >> Mobile: +94775505618 >> Blog:harshcreationz.blogspot.com >> >> _______________________________________________ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > _______________________________________________ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- Sameera Jayasoma, Software Architect, WSO2, Inc. (http://wso2.com) email: same...@wso2.com blog: http://sameera.adahas.org twitter: https://twitter.com/sameerajayasoma flickr: http://www.flickr.com/photos/sameera-jayasoma/collections Mobile: 0094776364456 Lean . Enterprise . Middleware
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
