adding Suho On Fri, Jan 16, 2015 at 11:13 PM, KasunG Gajasinghe <kas...@wso2.com> wrote:
> Hi, > > This feature will be merged into Kernel 4.4.0-SNAPSHOT. The downstream > projects should depend on kernel 4.3.0. So, there won't be any build breaks. > > Further, repo is currently depending carbon-multitenancy kernel 4.3.0. So, > we might have to wait until a release happens from that repo. Otherwise, we > will have to create a parallel branch. > > > On Fri, Jan 16, 2015 at 12:28 PM, Lakshman Udayakantha <lakshm...@wso2.com > > wrote: > >> Hi All, >> >> when I delete tenant in wso2as-6.0.0-SNAPSHOT, got the following exception >> >> Error executing query DELETE FROM UM_CLAIM_BEHAVIOR WHERE UM_TENANT_ID = >> ? for tenant: 1 >> >> org.h2.jdbc.JdbcSQLException: Table "UM_CLAIM_BEHAVIOR" not found; SQL >> statement: >> >> DELETE FROM UM_CLAIM_BEHAVIOR WHERE UM_TENANT_ID = ? [42102-140] >> >> at org.h2.message.DbException.getJdbcSQLException(DbException.java:327) >> >> at org.h2.message.DbException.get(DbException.java:167) >> >> >> seems like UM_CLAIM_BEHAVIOR table is not in database. How should I >> proceed in this case? >> >> On Thu, Jan 15, 2015 at 8:45 PM, Johann Nallathamby <joh...@wso2.com> >> wrote: >> >>> Was this code reviewed ? The new method in the listener does not follow >>> the same convention as others. It says "onPreDelete", but other methods >>> don't follow "pre/post" convention and you don't have hooks for all pre >>> process actions. >>> >>> Can you please add pre process hooks for all the methods in that case ? >>> Because if we miss to add it this time we won't be able to add it until >>> next major release of this repo. So please use the opportunity to fix it. >>> >>> Also the comment on the interface is not correct. It says something >>> specific to your implementation. >>> >>> On Wed, Jan 14, 2015 at 3:10 PM, Aruna Karunarathna <ar...@wso2.com> >>> wrote: >>> >>>> I believe we need to merge all these PR's related to tenant deletion at >>>> onetime coordinated manner. Otherwise there will be build breaks. >>>> >>>> >>>> Regards, >>>> Aruna >>>> >>>> On Wed, Jan 14, 2015 at 3:06 PM, Shashika Karunatilaka < >>>> shashi...@wso2.com> wrote: >>>> >>>>> Hi all, >>>>> >>>>> I have created PRs for the respective repositories(I have added a >>>>> comment in each PR). Please merge the Tenant deletion PRs and merge the >>>>> following PRs. >>>>> >>>>> *carbon-multitenancy* >>>>> >>>>> JIRA : <http://goog_2064092294/>https://wso2.org/jira/browse/WSAS-1882 >>>>> PR : https://github.com/wso2-dev/carbon-multitenancy/pull/16 >>>>> >>>>> *carbon-storage-management* >>>>> >>>>> JIRA : https://wso2.org/jira/browse/SS-454 >>>>> <https://github.com/wso2-dev/carbon-event-processing/pull/45> >>>>> PR : https://github.com/wso2-dev/carbon-storage-management/pull/97 >>>>> >>>>> *carbon-event-processing* >>>>> >>>>> JIRA : https://wso2.org/jira/browse/CEP-1000 >>>>> <https://github.com/wso2-dev/carbon-event-processing/pull/45> >>>>> PR : https://github.com/wso2-dev/carbon-event-processing/pull/45 >>>>> >>>>> *carbon-identity* >>>>> >>>>> JIRA : https://wso2.org/jira/browse/IDENTITY-2984 >>>>> <https://github.com/wso2-dev/carbon-event-processing/pull/45> >>>>> PR : https://github.com/wso2-dev/carbon-identity/pull/63 >>>>> >>>>> >>>>> Thank You >>>>> >>>>> On Mon, Jan 12, 2015 at 10:48 AM, Shashika Karunatilaka < >>>>> shashi...@wso2.com> wrote: >>>>> >>>>>> HI all, >>>>>> >>>>>> Below are my findings for the wso2 repos that uses the above >>>>>> listener class, please correct me if i missed any. >>>>>> >>>>>> >>>>>> Repo >>>>>> >>>>>> Componenent >>>>>> >>>>>> class >>>>>> >>>>>> carbon-multitenancy >>>>>> >>>>>> (org.wso2.carbon.theme.mgt.util) >>>>>> >>>>>> ThemeLoadingListener.java >>>>>> >>>>>> (org.wso2.carbon.keystore.mgt) >>>>>> >>>>>> KeystoreTenantMgtListener.java >>>>>> >>>>>> carbon-storage-management >>>>>> >>>>>> (org.wso2.carbon.cassandra.server) >>>>>> >>>>>> TenantCreationListener.java >>>>>> >>>>>> (org.wso2.carbon.hdfs.mgt) >>>>>> >>>>>> HDFSTenantCreationListener.java >>>>>> >>>>>> carbon-event-processing >>>>>> >>>>>> (org.wso2.carbon.event.stream.manager.core.internal.util.helper) >>>>>> >>>>>> TenantMgtListenerImpl.java >>>>>> >>>>>> carbon-identity >>>>>> >>>>>> (org.wso2.carbon.idp.mgt.internal ) >>>>>> >>>>>> TenantManagementListener.java >>>>>> >>>>>> (org.wso2.carbon.identity.application.authentication.framework.listener) >>>>>> >>>>>> >>>>>> AuthenticationEndpointTenantActivityListener.java >>>>>> >>>>>> product-af >>>>>> >>>>>> (org.wso2.carbon.appfactory.listners.tenant) >>>>>> >>>>>> AppFactoryTenantMgtListener.java >>>>>> >>>>>> (org.wso2.carbon.appfactory.s2.listeners) >>>>>> >>>>>> CloudEnvironmentPermissionListener.java >>>>>> >>>>>> (org.wso2.carbon.appfactory.stratos.listeners) >>>>>> >>>>>> CloudEnvironmentPermissionListener.java >>>>>> >>>>>> (org.wso2.carbon.appfactory.listners.tenant) >>>>>> >>>>>> DefaultRolesCreatorForTenant.java >>>>>> >>>>>> (org.wso2.carbon.appfactory.stratos.listeners) >>>>>> >>>>>> AppFactoryTenantKeyStoreMgtListener.java >>>>>> >>>>>> (org.wso2.carbon.appfactory.s2.listeners) >>>>>> >>>>>> AppFactoryTenantKeyStoreMgtListener.java >>>>>> >>>>>> (org.wso2.carbon.appfactory.listners.tenant) >>>>>> >>>>>> AppFactoryTenantActivationListener.java >>>>>> >>>>>> (org.wso2.carbon.appfactory.stratos.listeners) >>>>>> >>>>>> S2IntegrationTenantActivationListener.java >>>>>> >>>>>> (org.wso2.carbon.appfactory.s2.listeners) >>>>>> >>>>>> S2IntegrationTenantActivationListener.java >>>>>> >>>>>> private-paas >>>>>> >>>>>> (org.apache.stratos.theme.mgt.util) >>>>>> >>>>>> ThemeLoadingListener.java >>>>>> >>>>>> On Fri, Jan 9, 2015 at 8:47 PM, Shashika Karunatilaka < >>>>>> shashi...@wso2.com> wrote: >>>>>> >>>>>>> Hi all, >>>>>>> >>>>>>> I will include newly added method to all respective repositories of >>>>>>> *TenantMgtListener* interface, and also will create necessary JIRAs >>>>>>> >>>>>>> Thank you >>>>>>> >>>>>>> On Fri, Jan 9, 2015 at 1:02 PM, Lakshman Udayakantha < >>>>>>> lakshm...@wso2.com> wrote: >>>>>>> >>>>>>>> [fowarding to dev] >>>>>>>> >>>>>>>> Since new method introduced in *TenantMgtListener *interface, >>>>>>>> There may be build failures after committing this. how should we >>>>>>>> proceed with that? >>>>>>>> >>>>>>>> >>>>>>>> Hi Carbon team, >>>>>>>> >>>>>>>> Please review and merge the pull requests [1] and [2] that is >>>>>>>> include the changes in tenant deletion support. >>>>>>>> >>>>>>>> [1] https://github.com/wso2-dev/carbon4-kernel/pull/134 >>>>>>>> [2] https://github.com/wso2-dev/carbon-multitenancy/pull/15 >>>>>>>> >>>>>>>> Thanks >>>>>>>> -- >>>>>>>> Lakshman Udayakantha >>>>>>>> WSO2 Inc. www.wso2.com >>>>>>>> lean.enterprise.middleware >>>>>>>> Mobile: *0711241005 <0711241005>* >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Lakshman Udayakantha >>>>>>>> WSO2 Inc. www.wso2.com >>>>>>>> lean.enterprise.middleware >>>>>>>> Mobile: *0711241005 <0711241005>* >>>>>>>> >>>>>>>> >>>>>>>> _______________________________________________ >>>>>>>> Dev mailing list >>>>>>>> Dev@wso2.org >>>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Shashika Prabath Karunatilaka, >>>>>>> Software Engineer, >>>>>>> WSO2, Inc: http://wso2.com/ >>>>>>> mobile : +94 77 7487792 >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Shashika Prabath Karunatilaka, >>>>>> Software Engineer, >>>>>> WSO2, Inc: http://wso2.com/ >>>>>> mobile : +94 77 7487792 >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Shashika Prabath Karunatilaka, >>>>> Software Engineer, >>>>> WSO2, Inc: http://wso2.com/ >>>>> mobile : +94 77 7487792 >>>>> >>>> >>>> >>>> >>>> -- >>>> >>>> *Aruna Sujith Karunarathna* | Software Engineer >>>> WSO2, Inc | lean. enterprise. middleware. >>>> #20, Palm Grove, Colombo 03, Sri Lanka >>>> Mobile: +94 71 9040362 | Work: +94 112145345 >>>> Email: ar...@wso2.com | Web: www.wso2.com >>>> >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> Dev@wso2.org >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >>> >>> -- >>> Thanks & Regards, >>> >>> *Johann Dilantha Nallathamby* >>> Associate Technical Lead & Product Lead of WSO2 Identity Server >>> Integration Technologies Team >>> WSO2, Inc. >>> lean.enterprise.middleware >>> >>> Mobile - *+94777776950* >>> Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>* >>> >>> _______________________________________________ >>> Dev mailing list >>> Dev@wso2.org >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> Lakshman Udayakantha >> WSO2 Inc. www.wso2.com >> lean.enterprise.middleware >> Mobile: *0711241005 <0711241005>* >> >> >> _______________________________________________ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > > *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. > email: kasung AT spamfree wso2.com > linked-in: http://lk.linkedin.com/in/gajasinghe > blog: http://kasunbg.org > > > > _______________________________________________ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- Shashika Prabath Karunatilaka, Software Engineer, WSO2, Inc: http://wso2.com/ mobile : +94 77 7487792
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
