Hi Abishalani,

The link you have shared seems to be not accessible any more. However I was
able to access the draft proposal you have shared through GSOC Dashboard.

I have added few comments to the draft. Please go through them and try to
improve the proposal.

Thanks,

On Fri, Mar 24, 2017 at 11:16 PM, Abilashini Thiyagarajah <
abilashini...@cse.mrt.ac.lk> wrote:

> Hi Maduranga,
>
> I have already shared the draft of proposal [1] in the GSOC profile. Can I
> have your feedback on it please?
>
> [1] https://docs.google.com/document/d/1Jcye2kidM0KbaDVqXqtzVsEq_RJ_
> rOrcqpmqMAfpC3U/edit?usp=sharing
>
> Thank you
>
> *Thiyagarajah Abilashini*
> Student
> Department of Computer Science and Engineering
> University of Moratuwa, Sri Lanka
>
> On 21 March 2017 at 19:53, Maduranga Siriwardena <madura...@wso2.com>
> wrote:
>
>> Hi Abilashini,
>>
>> Please find my answers inline.
>>
>> On Tue, Mar 21, 2017 at 9:00 AM, Abilashini Thiyagarajah <
>> abilashini...@cse.mrt.ac.lk> wrote:
>>
>>> Hi,
>>>
>>> I am working on the proposal and need some clarifications on the
>>> project. Please correct me if I am wrong.
>>>
>>>    1. In the specification they did not talk about the validation of
>>>    requests. Is it required to be considered in the implementation?
>>>
>>> Yes you have to at least validate the mandatory parameters for the
>> requests. We can decide how much level of validation is needed when going
>> forward with the project.
>>
>>>
>>>    1. Does the deliverable of 'Automation for the implementation' mean
>>>    the implementation of Quick Start for the feature?
>>>
>>> This means the test cases for the project. Usually the integration tests
>> for the product are in [1]. I'm not sure whether we have test cases for
>> DCR. But you have to write test cases for the project. We don't have much
>> unit tests. But if you can write the unit tests also, it will be great.
>>
>>>
>>>    1. Test automation is not mentioned in the project deliverable. Also
>>>    I didn't find test classes in the implementation of DCR. So is testing 
>>> not
>>>    considered in the scope of this project?
>>>    2. This feature will be implemented within the implementation of
>>>    existing DCR component. Am I correct?
>>>
>>> Not necessarily within DCR component. We can decide whether
>> implementation should be. It can be a separate component in [2].
>>
>> [1] https://github.com/wso2/product-is/tree/5.x.x/modules/in
>> tegration/tests-integration
>> [2] https://github.com/wso2-extensions/identity-inbound-auth-oauth
>>
>> Thanks,
>>
>>
>>> Best Regards,
>>> Abilashini
>>>
>>> *Thiyagarajah Abilashini*
>>> Student
>>> Department of Computer Science and Engineering
>>> University of Moratuwa, Sri Lanka
>>>
>>> On 19 March 2017 at 10:08, Maduranga Siriwardena <madura...@wso2.com>
>>> wrote:
>>>
>>>> Hi Abishalani,
>>>>
>>>> The components are in <CARBON_HOME>/repository/components/plugins
>>>> folder. There you will find org.wso2.carbon.identity.
>>>> oauth.dcr_5.3.4.jar.
>>>>
>>>> You can checkout the tag v5.3.4 of the repository and then work through
>>>> the changes to the component. If you are going to apply the changes to the
>>>> product, you can build the jar and then create folder patch0001 (format of
>>>> the folder name should be "patch" and then a four digit number. Patches are
>>>> applied in the order of the number) in 
>>>> <CARBON_HOME>/repository/components/patches
>>>> and place the newly built jar inside that. After this you have to restart
>>>> the server. Please note that the for jars you are going patch name should
>>>> be equal to the original jar in dropins folder.
>>>>
>>>> If you successfully installed the changes, you will be able to notice a
>>>> log like below at the next start up.
>>>>
>>>> [2017-01-31 21:07:39,035]  INFO 
>>>> {org.wso2.carbon.server.extensions.PatchInstaller}
>>>> -  Patch changes detected  {org.wso2.carbon.server.exten
>>>> sions.PatchInstaller}
>>>> [2017-01-31 21:07:39,513]  INFO 
>>>> {org.wso2.carbon.server.util.PatchUtils.console}
>>>> -  Backed up plugins to patch0000 {org.wso2.carbon.server.util.P
>>>> atchUtils.console}
>>>> [2017-01-31 21:07:39,525]  INFO 
>>>> {org.wso2.carbon.server.util.PatchUtils.console}
>>>> -  Patch verification started {org.wso2.carbon.server.util.P
>>>> atchUtils.console}
>>>> [2017-01-31 21:07:39,530]  INFO 
>>>> {org.wso2.carbon.server.util.PatchUtils.console}
>>>> -  Patch verification successfully completed. 
>>>> {org.wso2.carbon.server.util.P
>>>> atchUtils.console}
>>>>
>>>> Thanks,
>>>>
>>>> On Sat, Mar 18, 2017 at 7:26 AM, Abilashini Thiyagarajah <
>>>> abilashini...@cse.mrt.ac.lk> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> I have worked to understand the specifications and code base related
>>>>> to OAuth 2.0 DCR protocol management. Now I am trying to fix some of the
>>>>> issues that you have shared with me. Can I know the location of dcr
>>>>> component in the server? Or else the way to try my code changes in the dcr
>>>>> component?
>>>>>
>>>>> Thanks in advance,
>>>>> Abilashini
>>>>>
>>>>> *Thiyagarajah Abilashini*
>>>>> Student
>>>>> Department of Computer Science and Engineering
>>>>> University of Moratuwa, Sri Lanka
>>>>>
>>>>> On 15 March 2017 at 10:26, Abilashini Thiyagarajah <
>>>>> abilashini...@cse.mrt.ac.lk> wrote:
>>>>>
>>>>>> Hi Maduranga,
>>>>>>
>>>>>> Thank you so much for your reply and references. I will work on to
>>>>>> understand the code and fix jira as you said.
>>>>>>
>>>>>> Best Regards,
>>>>>> Abilashini
>>>>>>
>>>>>> *Thiyagarajah Abilashini*
>>>>>> Student
>>>>>> Department of Computer Science and Engineering
>>>>>> University of Moratuwa, Sri Lanka
>>>>>>
>>>>>> On 15 March 2017 at 01:52, Maduranga Siriwardena <madura...@wso2.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi Abilashini,
>>>>>>>
>>>>>>> We are glad to see your interest in doing GSoC with WSO2.
>>>>>>>
>>>>>>> The requirement of the project is to fully implement the Dynamic
>>>>>>> Client Registration Management Protocol [1]. The current implementation 
>>>>>>> of
>>>>>>> Dynamic Client Registration is in repo [2] and particularly component in
>>>>>>> [3]. Documentation for OpenID Connect Dynamic Client Registration is in 
>>>>>>> [4].
>>>>>>>
>>>>>>> If you need to get familiarize with the code, you can fix jira
>>>>>>> already reported regarding dcr implementation which are in [5] (or you 
>>>>>>> can
>>>>>>> fix any jira in Identity Server project as a start).
>>>>>>>
>>>>>>> [1] https://tools.ietf.org/html/rfc7592
>>>>>>> [2] https://github.com/wso2-extensions/identity-inbound-auth-oauth
>>>>>>> [3] https://github.com/wso2-extensions/identity-inbound-auth
>>>>>>> -oauth/tree/master/components/org.wso2.carbon.identity.oauth.dcr
>>>>>>> [4] https://docs.wso2.com/display/IS530/OpenID+Connect+Dynam
>>>>>>> ic+Client+Registration
>>>>>>> [5] https://goo.gl/ghqqgE
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> On Tue, Mar 14, 2017 at 1:06 AM, Abilashini Thiyagarajah <
>>>>>>> abilashini...@cse.mrt.ac.lk> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> I am Abilashini from Department of Computer Science and
>>>>>>>> Engineering, University of Moratuwa. I have done my internship at WSO2 
>>>>>>>> last
>>>>>>>> year (July - December) and worked in the implementation of tomcat 
>>>>>>>> extension
>>>>>>>> of OpenID Connect [1]. So I am a little bit familiar with OAuth 2.0 and
>>>>>>>> OpenID Connect protocols. I found the project 'OAuth 2.0 Dynamic
>>>>>>>> Client Registration Management Protocol Support' as interesting to
>>>>>>>> work on. Can I have some assistance to understand the details and
>>>>>>>> requirements more clearly behind this project idea?
>>>>>>>> Also can I have the locations of documentation and code base
>>>>>>>> related to dynamic client registration?
>>>>>>>>
>>>>>>>> [1] https://github.com/wso2-extensions/tomcat-extension-openidsso
>>>>>>>>
>>>>>>>> Thanks and Regards
>>>>>>>> Abilashini
>>>>>>>>
>>>>>>>> *Thiyagarajah Abilashini*
>>>>>>>> Student
>>>>>>>> Department of Computer Science and Engineering
>>>>>>>> University of Moratuwa, Sri Lanka
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Maduranga Siriwardena
>>>>>>> Software Engineer
>>>>>>> WSO2 Inc; http://wso2.com/
>>>>>>>
>>>>>>> Email: madura...@wso2.com
>>>>>>> Mobile: +94718990591 <+94%2071%20899%200591>
>>>>>>> Blog: *https://madurangasiriwardena.wordpress.com/
>>>>>>> <https://madurangasiriwardena.wordpress.com/>*
>>>>>>> <http://wso2.com/signature>
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Maduranga Siriwardena
>>>> Software Engineer
>>>> WSO2 Inc; http://wso2.com/
>>>>
>>>> Email: madura...@wso2.com
>>>> Mobile: +94718990591 <+94%2071%20899%200591>
>>>> Blog: *https://madurangasiriwardena.wordpress.com/
>>>> <https://madurangasiriwardena.wordpress.com/>*
>>>> <http://wso2.com/signature>
>>>>
>>>
>>>
>>
>>
>> --
>> Maduranga Siriwardena
>> Software Engineer
>> WSO2 Inc; http://wso2.com/
>>
>> Email: madura...@wso2.com
>> Mobile: +94718990591 <+94%2071%20899%200591>
>> Blog: *https://madurangasiriwardena.wordpress.com/
>> <https://madurangasiriwardena.wordpress.com/>*
>> <http://wso2.com/signature>
>>
>
>


-- 
Maduranga Siriwardena
Senior Software Engineer
WSO2 Inc; http://wso2.com/

Email: madura...@wso2.com
Mobile: +94718990591
Blog: *https://madurangasiriwardena.wordpress.com/
<https://madurangasiriwardena.wordpress.com/>*
<http://wso2.com/signature>
_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to