vlsi commented on PR #105: URL: https://github.com/apache/xalan-java/pull/105#issuecomment-1774104757
@jkesselm , I have suggested the step-by-step guide a couple of days ago in https://github.com/apache/xalan-java/pull/105#issuecomment-1770141860 Here's a video of me following the exact steps: https://youtu.be/xnkfUGWFUWQ The video was not sped up. I just routinely go through renames. The renames I ended up with were slightly different from your current ones. For instance, you have `serializer/resources/...` while Maven convention is `serializer/src/main/resources`. There were several `.html -> .xhtml` renames left, however, I think xhtml should not be included in the current commit as file format is more like a personal preference rather than Maven requirement. Either way, it can be adjusted easily. Other than that, I believe, it confirms that 15 minutes was a reasonable estimation for splitting the renames. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
