jkesselm commented on PR #105:
URL: https://github.com/apache/xalan-java/pull/105#issuecomment-1775447221
CI is not part of this PR. It has its own. Discuss it there.
Taglet jarfile: Agree it can be pulled out. Nitpick accepted; I'll commit
that change.
The doclet jarfile stays for now. It is being kept as a reminder that we
need to sanity-check whether we should be using it; if so we should do a source
reconstruction for that too.
The XSLT samples need to be rewritten to not depend on the Sun zipfile
included in that module. Until that happens, it needs to stay, since I have
found no other source for it. (I haven't checked whether those samples actually
still run, decades after their submission; they should be updated, and probably
want test automation written.)
I
--
/_ Joe Kesselman (he/him/his)
-/ _) My Alexa skill for New Music/New Sounds fans:
/ https://www.amazon.com/dp/B09WJ3H657/
() Plaintext Ribbon Campaign
/\ Stamp out HTML mail!
________________________________
From: Vladimir Sitnikov ***@***.***>
Sent: Monday, October 23, 2023 3:25:08 AM
To: apache/xalan-java ***@***.***>
Cc: Joe Kesselman ***@***.***>; Mention ***@***.***>
Subject: Re: [apache/xalan-java] Migrate to Maven-based build (PR #105)
If so, I will probably close this PR and open a new on
Why split the history/discussion across several PRs?
if the user wants to open them up further they can do so, but unnecessary
execute permissions are asking for trouble.
If you feel the scripts are unsafe, just remove them from the repository.
If you feel the scripts are ok, then assign the proper execute bits.
Windows does not ask for execute bits, so you make the life of Linux/macOS
users harder for no reason as you remove the execute bits.
________________________________
I guess you need to settle on xalan2jtaglet.jar. You both move
xalan2jtaglet.jar to various locations, and add decompiled sources at the same
time.
Testing is in progress
I've no idea how you test, however, I hope you'll add CI sooner rather than
later.
________________________________
I guess you should not put package.xhtml into site as package.html is
javadoc-related rather than site-related.
Keeping package.html alone would reduce the noise in the second commit, and
it would improve the generated javadocs at the same time.
________________________________
Does that satisfy, or are there further quibbles?
Would you scan through the second commit to identify excessive changes like
xalan/tools/xalan2jdoc.jar, serializer/tools/xalan2jdoc.jar, and so on?
Try something git diff -M --diff-filter=AR --name-status origin/master.
Ideally, the second commit should not contain renames (unless you rename
classes for some reason), and it should not contain the addition of unwanted
files (e.g. jars)
—
Reply to this email directly, view it on
GitHub<https://github.com/apache/xalan-java/pull/105#issuecomment-1774580602>,
or
unsubscribe<https://github.com/notifications/unsubscribe-auth/A7OJ6W7E3AG3M4X5EDZPL5LYAYLVJAVCNFSM6AAAAAA6EOLZ5GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUGU4DANRQGI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
