jkesselm commented on PR #105:
URL: https://github.com/apache/xalan-java/pull/105#issuecomment-1774126894
As I said, the Maven documentation plug-in supports xhtml, not html.
Otherwise, I agree, I wouldn't have changed it.
Location of resources/: valid point. Need to check that output is still
consistent, and tweak appropriately if not, but I agree that's an improvement.
Thanks for the illustrated guide. I just wasn't seeing the path to get
there, even with the description. Let's see if I can replicate this.
(If not, we could check in your version as another branch, diff/test to
confirm, then issue the PR from there; history on the individual file changes
would be the same but you'd be credited for the moves, which would be fine. But
lemme make the attempt to sort mine first.)
--
/_ Joe Kesselman (he/him/his)
-/ _) My Alexa skill for New Music/New Sounds fans:
/ https://www.amazon.com/dp/B09WJ3H657/
() Plaintext Ribbon Campaign
/\ Stamp out HTML mail!
________________________________
From: Vladimir Sitnikov ***@***.***>
Sent: Sunday, October 22, 2023 10:06:43 AM
To: apache/xalan-java ***@***.***>
Cc: Joe Kesselman ***@***.***>; Mention ***@***.***>
Subject: Re: [apache/xalan-java] Migrate to Maven-based build (PR #105)
@jkesselm<https://github.com/jkesselm> , I have suggested the step-by-step
guide a couple of days ago in #105
(comment)<https://github.com/apache/xalan-java/pull/105#issuecomment-1770141860>
Here's a video of me following the exact steps: https://youtu.be/xnkfUGWFUWQ
The video was not sped up. I just routinely go through renames.
The renames I ended up with were slightly different from your current ones.
For instance, you have serializer/resources/... while Maven convention is
serializer/src/main/resources.
There were several .html -> .xhtml renames left, however, I think xhtml
should not be included in the current commit as file format is more like a
personal preference rather than Maven requirement. Either way, it can be
adjusted easily.
Other than that, I believe, it confirms that 15 minutes was a reasonable
estimation for splitting the renames.
—
Reply to this email directly, view it on
GitHub<https://github.com/apache/xalan-java/pull/105#issuecomment-1774104757>,
or
unsubscribe<https://github.com/notifications/unsubscribe-auth/A7OJ6WY6SEQIZYP35KTCWSTYAUR7HAVCNFSM6AAAAAA6EOLZ5GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUGEYDINZVG4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
