kubycsolutions commented on PR #120:
URL: https://github.com/apache/xalan-java/pull/120#issuecomment-1811740221
With all the emphasis on "use Maven defaults", I presumed that the official
Apache assembly descriptors were sufficiently robust to be preferred unless we
had special needs.
If that isn't the case I can certainly reintroduce my own descriptor for the
source bundle.
Might be moving in that direction anyway, to get everything that was in the
Ant distribution to be present in the Maven version (modulo deliberate changes).
--
/_ Joe Kesselman (he/him/his)
-/ _) My Alexa skill for New Music/New Sounds fans:
/ https://www.amazon.com/dp/B09WJ3H657/
() I still don't think HTML mail is a good idea
/\ but Outlook/Android is insisting. Need to
change mail client.
________________________________
From: Alexander Kriegisch ***@***.***>
Sent: Tuesday, November 14, 2023 9:23:00 PM
To: apache/xalan-java ***@***.***>
Cc: Joseph Kesselman ***@***.***>; Mention ***@***.***>
Subject: Re: [apache/xalan-java] Reformat Maven POM and assembly XML, no
functional changes (PR #120)
Oh, I see what you are doing, using a centrally provided Apache plugin
dependency for Assembly Plugin to be used on top level. Well, I kind of
understand that this is easier than to custom-build your own assembly
desceriptor. OTOH, this leads to directories being included that do not belong
into the source distro. For example, I made some local changes to your
project's Shade Plugin config, copying the resulting source/binary assemblies
into a _tmp subdirectory before and after the change to be able to diff them
afterwards. The whole _tmp subdirectory with dozens of MB of binaries ended up
in the source distro. I.e., you need to be quite careful what is in your local
workspace when running the build.
—
Reply to this email directly, view it on
GitHub<https://github.com/apache/xalan-java/pull/120#issuecomment-1811700194>,
or
unsubscribe<https://github.com/notifications/unsubscribe-auth/AOKT7A6YH4IW7QLO5YEM2UDYEQRQJAVCNFSM6AAAAAA7KFDX4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJRG4YDAMJZGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
