jkesselm commented on PR #120:
URL: https://github.com/apache/xalan-java/pull/120#issuecomment-1812529548
Good catch!
Xalan currently promises to run on JRE 8. That doesn't absolutely require
that we build on JDK 8, I suppose, but I want to retain the ability to do so.
For now, that rules out requiring 9+.
But we'll move forward someday. And users may want to build their own copies
on newer versions.
It's orthogonal to the Maven migration, though. So I think the right thing
to do is open it as a Jira Issue and get back to it.
Fourth option: make the taglet itself introspect and pick the right set of
APIs.
--
/_ Joe Kesselman (he/him/his)
-/ _) My Alexa skill for New Music/New Sounds fans:
/ https://www.amazon.com/dp/B09WJ3H657/
() I still don't think HTML mail is a good idea
/\ but Outlook/Android is insisting. Need to
change mail client.
________________________________
From: Alexander Kriegisch ***@***.***>
Sent: Tuesday, November 14, 2023 10:54:57 PM
To: apache/xalan-java ***@***.***>
Cc: Joe Kesselman ***@***.***>; Comment ***@***.***>
Subject: Re: [apache/xalan-java] Reformat Maven POM and assembly XML, no
functional changes (PR #120)
Another question is if you really want to force every developer to run the
build on JDK 8 just because of the taglet dependencies on old com.sun JDK
packages, which have been superseded by others on JDK 9+. Basically, you have 3
options:
* Continue as is.
* Require JDK 9+ for the build and migrate the taglet thingy to the new
API standard.
* Add a JDK 9+ variant of the taglet code on top of the JDK 8 version
and configure the build to use one on JDK 8 and the other on JDK 9+.
WDYT?
—
Reply to this email directly, view it on
GitHub<https://github.com/apache/xalan-java/pull/120#issuecomment-1811769128>,
or
unsubscribe<https://github.com/notifications/unsubscribe-auth/A7OJ6WZESL4RU3ABNFY5JQLYEQ4JDAVCNFSM6AAAAAA7KFDX4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJRG43DSMJSHA>.
You are receiving this because you commented.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
