kubycsolutions commented on PR #120:
URL: https://github.com/apache/xalan-java/pull/120#issuecomment-1811747241
Again, my understanding was that Maven preferred central definition and
local use. Certainly I'd rather have the things which are common to all the
modules factored upward when that makes sense, to keep things reliably in sync.
It's starting to feel like there are a lot of exceptions to stated Maven
philosophies. I can live with that, I understand that tools get gruesome
because they grew some... But I don't _think_ anything I'm trying to achieve is
that unusual for Apache tools.
--
/_ Joe Kesselman (he/him/his)
-/ _) My Alexa skill for New Music/New Sounds fans:
/ https://www.amazon.com/dp/B09WJ3H657/
() I still don't think HTML mail is a good idea
/\ but Outlook/Android is insisting. Need to
change mail client.
________________________________
From: Alexander Kriegisch ***@***.***>
Sent: Tuesday, November 14, 2023 8:31:12 PM
To: apache/xalan-java ***@***.***>
Cc: Joseph Kesselman ***@***.***>; Mention ***@***.***>
Subject: Re: [apache/xalan-java] Reformat Maven POM and assembly XML, no
functional changes (PR #120)
I have a hunch: Remember when I said that you should not define plugins
globally in the parent POM, at least not ones you only need in some modules? I
see that you have quite a list of stuff going on there. For the source
assemblies, you can get away with it, using the special runOnlyAtExecutionRoot
parameter. But that kind of special parameter is e.g. unavailable for Maven
Shade, which is also defined in the parent POM and therefore executes for each
module, each tinme saying "Replacing original artifact with shaded artifact".
the original artifact for pom artifact types probably is the pom.xml file
itself, which is why it might get overwritten in your case, even though not in
mine. Assembly for the source archive also runs for each module, albeit with a
"Skipping the assembly in this project because it's not the Execution Root"
message.
—
Reply to this email directly, view it on
GitHub<https://github.com/apache/xalan-java/pull/120#issuecomment-1811657436>,
or
unsubscribe<https://github.com/notifications/unsubscribe-auth/AOKT7A6QRMW23GPPYLGFUITYEQLOBAVCNFSM6AAAAAA7KFDX4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJRGY2TONBTGY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
