Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-181140583
Thanks for the contribution.
I think `spark/lib/rscala_2.10-1.0.6.jar` shouldn't be included in the
source tree. Can this be downloaded on build time?
And `rscala_2.10-1.0.6.jar` looks like available on BSD license according
to [here](https://cran.r-project.org/web/packages/rscala/index.html). Then,
you'll need add license of the library into
`zeppelin-distribution/src/bin_license/LICENSE`, and add
[LICENSE](https://cran.r-project.org/web/packages/rscala/LICENSE) file under
`zeppelin-distribution/src/bin_license/licenses` directory.
Most interpreters include at least one unittest or integration test. So I
suggest have an test.
I think R interpreter related source file need to be excluded for profile
spark-1.3, spark-1.2, spark-1.1, so CI doesn't fail for those profile. I think
maven capable of doing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
