Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-181624753
  
    Guys, R interpreter is a big important and complicated contribution, hope 
we could make our last push to get that merged. 
    
    On my spare time I briefly went thought the this PR again and listed (in 
order of importance) a few things that I think we need to complete to speed 
things up and merge this one.
    
    @elbamos @justsomeone1001 @sourav-mazumder @Leemoonsoo @felixcheung  please 
let me know what do you think about this plan.
    
     1. [ ] fraction out changes to other modules out of this PR (will make 
things simpler to test and review)
        * `spark-dependencies/pom.xml`
        * `spark/pom.xml`
      It should be possible to re-create them as a separate PRs if needed.
    
     1. [ ] rebase on top of latest master
    
     1. [ ] add\point to Docs
    
        AFAIK for a user to enjoy R interpreter, there are some pre-requests 
like packages to be installed, etc. Is there any documentation on 'how to 
setup' the environment? 
       If we could have one under `/docs/` - that would be awesome. It's very 
easy to add, but this would be very helpful to make more people use it and help 
us testing it. Here are 
[docs](http://zeppelin.incubator.apache.org/docs/0.6.0-incubating-SNAPSHOT/development/howtocontributewebsite.html)
 on how to do that.
    
     1. [ ] *(alex)* CI failing.
    
     1. [ ] clarify minor copyright issue in `r/R/rzeppelin`
    
       
[r/R/rzeppelin/LICENSE](https://github.com/apache/incubator-zeppelin/pull/208/files#diff-70a1eaac699ff7afe9f107a9aafe976dR2)
 rises the question:
        is `r/R/rzeppelin/*` a [work under 
ASF](http://www.apache.org/legal/src-headers.html#headers) or is that a 
[third-party code](http://www.apache.org/legal/src-headers.html#3party)?
    
       in either case, from my understanding, it needs to be updated according 
to the links above (either by adding ASF headers to all the files and removing 
LICENSE, or by listing it in root project's NOTICE file)
    
     1. [ ] fix `/r/pom.xml` formatting
     1. [ ] make sure all other source code formatting is consistent
        Like [this]( 
https://github.com/apache/incubator-zeppelin/pull/208/files#diff-b1e5f7257eb27da9958f26d8c763d242R143),
 
[this](https://github.com/apache/incubator-zeppelin/pull/208/files#diff-b1e5f7257eb27da9958f26d8c763d242R153)
 and 
[that](https://github.com/apache/incubator-zeppelin/pull/208/files#diff-728dfe61ffb885af17a8b5c7efb44e75R37),
 etc
    
     
    If somebody could start with 1-3, I will be happy to help with 4 ASAP, 
hopefully will have more spare cycles by the end of the week.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to