Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-182916680
  
    Guys, thank you for the feedback!
    To pursue our plan I have summarize it after the discussion and took the 
liberty of mentioning those who volunteered to help.  
    
    
     1. [ ] *(amos)* remove changes that are *not required* from this PR, in 
particular in other modules
        * `spark-dependencies/pom.xml`
        * `spark/pom.xml`
    
      Create new PRs with those issues.
    
     1. [ ] *(amos)* rebase all work on top of latest master
    
     1. [ ] *(amos, sourav)* add\point to Docs
       Move awesome docs from README of 
https://github.com/elbamos/Zeppelin-With-R to the `/docs/`. Here are 
[instructions](http://zeppelin.incubator.apache.org/docs/0.6.0-incubating-SNAPSHOT/development/howtocontributewebsite.html)
 on how to do that.
    
     1. [ ] *(alex)* fix CI failure.
    
     1. [ ] clarify minor copyright issue in `r/R/rzeppelin`
    
        All contributed files (generated as well) should have Apache header, 
`LICENSE` file removed, third-party under BSD license should not be changed, 
but mentioned in `zeppelin-distribution/src/bin_license/LICENSE`
    
     1. [ ] fix `/r/pom.xml` formatting: i.e indention 
[here](https://github.com/apache/incubator-zeppelin/pull/208/files#diff-16eca63f53c817ad231bb79821f6a33dR49)
 and 
[here](https://github.com/apache/incubator-zeppelin/pull/208/files#diff-16eca63f53c817ad231bb79821f6a33dR106)
    
     1. [ ] **(amos)** make sure all other source code formatting is consistent
        Like [this]( 
https://github.com/apache/incubator-zeppelin/pull/208/files#diff-b1e5f7257eb27da9958f26d8c763d242R143),
 
[this](https://github.com/apache/incubator-zeppelin/pull/208/files#diff-b1e5f7257eb27da9958f26d8c763d242R153)
 and 
[that](https://github.com/apache/incubator-zeppelin/pull/208/files#diff-728dfe61ffb885af17a8b5c7efb44e75R37),
 etc
    
    
    -----
    
    Further improvements (in next PR after this got merged):
     - update build scripts: either add R a module, or builds only if R is 
present. 
     - include R interpreter in the binary build
    
    better be taken care of in further PRs (will be glad to help).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to