Github user johnnyws commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/796#issuecomment-205653556
@felizbear the problem is that we are using notebook name to represent
paths, and we allow notebooks with same name. Thus, I think having 2 notebooks
with the same name (such as `/this/is/a/file`) should be valid. Then we
actually allow the notebooks in the same folder having the same name. (I am
trying to avoid using the term of "file" here, because for file systems, we do
not allow files with same name in the same directory, but our case is slightly
different from a typical file system).
This issue may make the implementation more complicated if we use map-like
data structures, because we need to deal with the case with duplicates. Thus, I
think it may be more appropriate to use list-based data structures.
I do agree that the code quality is very important, and I admit that the
current logic of folder construction is a little bit messy. I would like to
refactor the code once we have an agreement on either to use map-based data
structure or link-based data structure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
