[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050844#comment-13050844
 ] 

Camille Fournier commented on ZOOKEEPER-1097:
---------------------------------------------

Will clean up small bits.

Will rename isQuotaSet. It's really just exposed so this thing can be tested in 
some way. Do you still want javadoc?

Yes, the start/stop/start/stop is necessary to get the load to be from 
snapshot, instead of txn log. Without that the test will pass with the bug 
still there.

I think assertNotNull is best of all, if we're going to pick that particular 
nit. Or did you really want the actual value?



> Quota is not correctly rehydrated on snapshot reload
> ----------------------------------------------------
>
>                 Key: ZOOKEEPER-1097
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1097
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.3.3, 3.4.0
>            Reporter: Camille Fournier
>            Assignee: Camille Fournier
>            Priority: Blocker
>             Fix For: 3.3.4, 3.4.0
>
>         Attachments: ZOOKEEPER-1097.patch
>
>
> traverseNode in DataTree will never actually traverse the limit nodes 
> properly.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to