[
https://issues.apache.org/jira/browse/ZOOKEEPER-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051428#comment-13051428
]
Henry Robinson commented on ZOOKEEPER-1097:
-------------------------------------------
Thanks for updating the patch. Looks nearly good to go.
* You've included a bunch of changes to eclipse project files. Can you remove
them?
* Javadoc looks good, thanks. In general, if you're making a method public for
testing only, it's worth commenting on that. Guava has a nice
@VisibleForTesting annotation that makes that explicit, but we don't depend on
that right now. (It's weird that our tests are in different packages to the
classes they test...)
* FWIW, I really did mean assertEquals, for the lines where you have things
like:
Assert.assertTrue("count is set", qst.getCount() == 2);
* Also turns out the messages in those asserts are inverted - they get shown
when the assertion fails, so you'll see "Assertion failed: count is set" which
is the precise opposite of what's gone wrong :)
* ...aaaand while we're here, the indentation for the stopServer / startServer
block seems to be tabs rather than spaces. Actually, there are a bunch of other
places with tabs, I think. Would you mind changing them to be spaces
consistently?
Thanks for bearing with me.
> Quota is not correctly rehydrated on snapshot reload
> ----------------------------------------------------
>
> Key: ZOOKEEPER-1097
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1097
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.3, 3.4.0
> Reporter: Camille Fournier
> Assignee: Camille Fournier
> Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1097, ZOOKEEPER-1097.patch,
> ZOOKEEPER-1097.patch
>
>
> traverseNode in DataTree will never actually traverse the limit nodes
> properly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
