basic cleanup in LearnerHandler
-------------------------------

                 Key: ZOOKEEPER-1234
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1234
             Project: ZooKeeper
          Issue Type: Sub-task
            Reporter: Thomas Koch
            Assignee: Thomas Koch


- order class members: properties, constructor, methods
- make properties private final
- rename version to protocolVersion
- The integer value 0x10000 should be extracted to a constant with a 
declarative name. But since I don't yet fully understand its purpose, I've no 
idea for the name of the constant.
- Initialize properties BinaryInpuutArchive ia, BinaryOutputArchive oa and 
BuferedOutputSream bufferedOutput in the constructor so that they can be made 
final.
- Remove call to sock.setSoTimeout. All two users of the class set the 
sockettimeout anyways themselfes. This also removes a link to the Leader class.
- remove unused method packetToString.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to