[
https://issues.apache.org/jira/browse/ZOOKEEPER-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129597#comment-13129597
]
Hadoop QA commented on ZOOKEEPER-1234:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12499515/ZOOKEEPER-1234.patch
against trunk revision 1185233.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/624//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/624//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/624//console
This message is automatically generated.
> basic cleanup in LearnerHandler
> -------------------------------
>
> Key: ZOOKEEPER-1234
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1234
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Attachments: ZOOKEEPER-1234.patch
>
>
> - order class members: properties, constructor, methods
> - make properties private final
> - rename version to protocolVersion
> - The integer value 0x10000 should be extracted to a constant with a
> declarative name. But since I don't yet fully understand its purpose, I've no
> idea for the name of the constant.
> - Initialize properties BinaryInpuutArchive ia, BinaryOutputArchive oa and
> BuferedOutputSream bufferedOutput in the constructor so that they can be made
> final.
> - Remove call to sock.setSoTimeout. All two users of the class set the
> sockettimeout anyways themselfes. This also removes a link to the Leader
> class.
> - remove unused method packetToString.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
