[
https://issues.apache.org/jira/browse/ZOOKEEPER-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131382#comment-13131382
]
jirapos...@reviews.apache.org commented on ZOOKEEPER-1234:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2421/#review2696
-----------------------------------------------------------
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java
<https://reviews.apache.org/r/2421/#comment6080>
we should keep this - it's useful when debugging. unfort QP is generated so
we can't add toString there. thoughts?
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java
<https://reviews.apache.org/r/2421/#comment6081>
this removal is problematic
1) the test caller is probably fine - it's overriding the setting
2) however Leader.java is using syncLimit, not initLimit. this may indicate
a bug in the existing code? Ben/Flavio/Henry might know for sure.
- Patrick
On 2011-10-18 08:46:17, Thomas Koch wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2421/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-18 08:46:17)
bq.
bq.
bq. Review request for zookeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. .
bq.
bq.
bq. This addresses bug ZOOKEEPER-1234.
bq. https://issues.apache.org/jira/browse/ZOOKEEPER-1234
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java
c518792
bq.
bq. Diff: https://reviews.apache.org/r/2421/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Thomas
bq.
bq.
> basic cleanup in LearnerHandler
> -------------------------------
>
> Key: ZOOKEEPER-1234
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1234
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Attachments: ZOOKEEPER-1234.patch
>
>
> - order class members: properties, constructor, methods
> - make properties private final
> - rename version to protocolVersion
> - The integer value 0x10000 should be extracted to a constant with a
> declarative name. But since I don't yet fully understand its purpose, I've no
> idea for the name of the constant.
> - Initialize properties BinaryInpuutArchive ia, BinaryOutputArchive oa and
> BuferedOutputSream bufferedOutput in the constructor so that they can be made
> final.
> - Remove call to sock.setSoTimeout. All two users of the class set the
> sockettimeout anyways themselfes. This also removes a link to the Leader
> class.
> - remove unused method packetToString.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
