[
https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193482#comment-13193482
]
Patrick Hunt commented on ZOOKEEPER-1366:
-----------------------------------------
I don't think so Ben (on both counts).
Has this been reviewed fully? I'm looking at it now for the first time and I
notice a pretty serious issue right off the bat.
Given the docs say the following for nanotime
bq. This method can only be used to measure elapsed time and is not related to
any other notion of system or wall-clock time.
the following is going to be a major headache:
{noformat}
cnxn.updateStatsForResponse(request.cxid, request.zxid, lastOp,
- request.createTime, System.currentTimeMillis());
+ request.createTime, Time.currentElapsedTime());
{noformat}
We shouldn't be using nanotime in any place where we display a date/time to a
user. (ie ONLY use it to measure elapsed time)
I think we should just put this into trunk only.
> Zookeeper should be tolerant of clock adjustments
> -------------------------------------------------
>
> Key: ZOOKEEPER-1366
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1366
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Ted Dunning
> Assignee: Ted Dunning
> Fix For: 3.4.3
>
> Attachments: ZOOKEEPER-1366-3.3.3.patch, ZOOKEEPER-1366.patch,
> ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch
>
>
> If you want to wreak havoc on a ZK based system just do [date -s "+1hour"]
> and watch the mayhem as all sessions expire at once.
> This shouldn't happen. Zookeeper could easily know handle elapsed times as
> elapsed times rather than as differences between absolute times. The
> absolute times are subject to adjustment when the clock is set while a timer
> is not subject to this problem. In Java, System.currentTimeMillis() gives
> you absolute time while System.nanoTime() gives you time based on a timer
> from an arbitrary epoch.
> I have done this and have been running tests now for some tens of minutes
> with no failures. I will set up a test machine to redo the build again on
> Ubuntu and post a patch here for discussion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
