[ https://issues.apache.org/jira/browse/ZOOKEEPER-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790123#comment-13790123 ]
Hadoop QA commented on ZOOKEEPER-1459: -------------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12607524/ZOOKEEPER-1459.patch against trunk revision 1530166. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1667//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1667//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1667//console This message is automatically generated. > Standalone ZooKeeperServer is not closing the transaction log files on > shutdown > ------------------------------------------------------------------------------- > > Key: ZOOKEEPER-1459 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1459 > Project: ZooKeeper > Issue Type: Bug > Components: server > Affects Versions: 3.4.0 > Reporter: Rakesh R > Assignee: Rakesh R > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch, > ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch > > > When shutdown the standalone ZK server, its only clearing the zkdatabase and > not closing the transaction log streams. When tries to delete the temporary > files in unit tests on windows, its failing. > ZooKeeperServer.java > {noformat} > if (zkDb != null) { > zkDb.clear(); > } > {noformat} > Suggestion to close the zkDb as follows, this inturn will take care > transaction logs: > {noformat} > if (zkDb != null) { > zkDb.clear(); > try { > zkDb.close(); > } catch (IOException ie) { > LOG.warn("Error closing logs ", ie); > } > } > {noformat} -- This message was sent by Atlassian JIRA (v6.1#6144)