[
https://issues.apache.org/jira/browse/ZOOKEEPER-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13806581#comment-13806581
]
Rakesh R commented on ZOOKEEPER-1459:
-------------------------------------
[~davidlao] You are right, ServerCnxnFactory is not closing the transaction
log. Sorry for the confusion. I had commented by looking at your patch, its
trying to fix the transaction log separately in ZooKeeperServer. This is not
required as ZKDatabase is holding the reference to txnLogFactory and zkDatabase
will close transaction log also.
bq.To your second point I agree the log closing is better done outside the
server in runFromConfig. I've verified the patch works on by Windows box.
Thanks [~davidlao] for the testing effort.
bq.Both patches, from Rakesh R and David Lao, hang on
org.apache.zookeeper.server.ZxidRolloverTest for me.
[~fpj], Thanks again for the reviews. In the latest patch I tried to fix the
problem in ZooKeeperServerMain.java class. One thing I'm not able to understand
is, why this fix is affecting ZxidRolloverTest testcases. Because am not seeing
any relation ship between ZxidRolloverTest and transaction log closure in
ZooKeeperServerMain:(. I hope you are looking at the latest patch which I
attached on "Last Friday 17:244"
For understanding the problem, it would be good if you can share logs,
threaddumps etc. Is this consistently failiing and which test case in
ZxidRolloverTest ?
> Standalone ZooKeeperServer is not closing the transaction log files on
> shutdown
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1459
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1459
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.4.0
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch,
> ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch,
> ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch
>
>
> When shutdown the standalone ZK server, its only clearing the zkdatabase and
> not closing the transaction log streams. When tries to delete the temporary
> files in unit tests on windows, its failing.
> ZooKeeperServer.java
> {noformat}
> if (zkDb != null) {
> zkDb.clear();
> }
> {noformat}
> Suggestion to close the zkDb as follows, this inturn will take care
> transaction logs:
> {noformat}
> if (zkDb != null) {
> zkDb.clear();
> try {
> zkDb.close();
> } catch (IOException ie) {
> LOG.warn("Error closing logs ", ie);
> }
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
